Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminates all machine detection outside detech_machine.sh #2324

Conversation

HenryRWinterbottom
Copy link
Contributor

Description

This PR addresses issue #2129. The following is accomplished:

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Testing was performed on RDHPCS Hera. A C96 3DVAR experiment was configured and run such that ush/load_fv3gfs_modules.sh and ufs/load_ufsda_modules.sh are excercised. The following global-workflow configurtaion was used:

./setup_expt.py gfs cycled --app ATM --resdetatmos 96 --comroot ${WORKSPACE}/COMROOT --expdir ${WORKSPACE}/EXPDIR --idate 2021122018 --edate 2021122100 --pslot x005_gwdev_issue_2129 --icsdir /scratch1/NCEPDEV/global/glopara/data/ICSDIR/C96C48/ --nens 0

The following is the Rocoto status for the relevant tasks:

       CYCLE                    TASK                       JOBID               STATE         EXIT STATUS     TRIES      DURATION
================================================================================================================================
202112201800                gdasfcst                    55777855           SUCCEEDED                   0         1         445.0
202112201800    gdasatmos_prod_f000-f003                    55778107           SUCCEEDED                   0         1          89.0
202112201800    gdasatmos_prod_f006-f009                    55778108           SUCCEEDED                   0         1          89.0
202112201800                gdasarch                    55778697           SUCCEEDED                   0         1          13.0
================================================================================================================================
202112210000                gdasprep                    55778698           SUCCEEDED                   0         1         223.0
202112210000                gdasanal                    55778888           SUCCEEDED                   -         0           0.0
202112210000                 gfsprep                    55778699           SUCCEEDED                   0         1         207.0
202112210000                 gfsanal                    55778889           SUCCEEDED                   0         1         836.0
202112210000               gfssfcanl         druby://hfe03:41621          SUBMITTING    

Note that the DA tasks, specifically gfsanal and gdasanal run to completion.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

ush/load_ufsda_modules.sh Fixed Show fixed Hide fixed
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be condensed with case. See suggestions.

ush/load_fv3gfs_modules.sh Outdated Show resolved Hide resolved
ush/load_ufsda_modules.sh Outdated Show resolved Hide resolved
ush/load_ufsda_modules.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now.

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @HenryWinterbottom-NOAA !

@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Feb 22, 2024
7 tasks
@DavidHuber-NOAA
Copy link
Contributor

This was merged with #2239.

@HenryRWinterbottom HenryRWinterbottom deleted the feature/gwdev_issue_2129 branch April 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate all machine detection outside of detect_machine.sh
5 participants