[NCO Bug] Fix compilation error with "-check all" for gfs_bufrsnd

[KateFriedman-NOAA]

Bugzilla: #1208

NCO requested that -check all option be corrected to work with gfs_bufrsnd code. Details from bugzilla below:

We tested the gfs.v16.0.7 source code to compile with "-check all" option,  the gfs_bufrsnd failed during the compilation. 

Here is the error:

"meteorg.f(1108): error #5560: Subscript #1 of the array ZP2 has value 11 which is greater than the upper bound of 2
       print*,'finish computing zp2(11-12) ', zp2(11),zp2(12)
----------------------------------------------^
meteorg.f(1108): error #5560: Subscript #1 of the array ZP2 has value 12 which is greater than the upper bound of 2
       print*,'finish computing zp2(11-12) ', zp2(11),zp2(12)
------------------------------------------------------^
compilation aborted for meteorg.f (code 1)
make: *** [meteorg.o] Error 1
"

Please check your code with "-check all" option and fix the problem by next upgrade. 

Notes that the "-check all" is not used to compile in production running code. Just for code stability test.

Please change line 1108 from
 print*,'finish computing zp2(11-12) ', zp2(11),zp2(12)
to 
 print*,'finish computing zp2(1-2) ', zp2(1),zp2(2)

[HuiyaChuang-NOAA]

@ShelleyMelchior-NOAA I believe this should be assigned to Bo Cui.
I am not certain if I am permitted to assign github issue to a contractor so am including you in this case

[ShelleyMelchior-NOAA]

Ok, thanks for the notice, @HuiyaChuang-NOAA . I don't think I have permissions to identify an asignee. @KateFriedman-NOAA , I am Bo's contract branch leader. Can you assign this github issue to @BoCui-NOAA for me?

[KateFriedman-NOAA]

@ShelleyMelchior-NOAA Given your request, I have assigned this issue to @BoCui-NOAA . Thanks!

[BoCui-NOAA]

@KateFriedman-NOAA Got the assigned! Thanks! What's the schedule to give you the updated gfs_bufsnd?

[KateFriedman-NOAA]

@BoCui-NOAA Would the end of FY23Q2 (end of March) be reasonable to you?

[BoCui-NOAA]

@BoCui-NOAA Would the end of FY23Q2 (end of March) be reasonable to you?

Sure, work for me. I will test the "-check all" option. Do you know which file and line that NCO adds this option for code stability test? Thanks!

[HuiyaChuang-NOAA]

@BoCui-NOAA I know you're working on NAEFS upgrade to be implemented at the end of year so please feel free to speak up if this update to GFS Bufr needs to be postponed.

[BoCui-NOAA]

@HuiyaChuang-NOAA I'll speak up and postpone the test if I can't meet the due date, thanks very much for your consideration.

[KateFriedman-NOAA]

Do you know which file and line that NCO adds this option for code stability test?

@BoCui-NOAA Do you have access to the bugzillas? That would be a good place to ask NCO. If you don't, I can ask in there.

[BoCui-NOAA]

@KateFriedman-NOAA I already accessed to the bugzillas and asked the question. Thanks!

[WalterKolczynski-NOAA]

Since the source code is now in NOAA-EMC/gfs-utils, there should be a companion issue opened there for the work (although I think we want to move it to UFS-Utils).