Bugfix/ounp #263
Bugfix/ounp #263
Conversation
fixed file name for ww3_ounf output See merge request wave/WW3!1
bugfix for netcdf file id allocation See merge request wave/WW3!2
extra line in ww3_shel See merge request wave/WW3!4
add comment
Feature/fixedname See merge request wave/WW3!5
add WCOR to switch list See merge request wave/WW3!6
add check on array index See merge request wave/WW3!7
Merge branch 'develop' of https://gitlab.ifremer.fr/wave/WW3 into develop
…into feature/ST4tail Conflicts: model/ftn/w3gdatmd.ftn model/ftn/w3src4md.ftn model/ftn/ww3_grid.ftn
…into feature/ST4tail
…test." This reverts commit f2a653b.
to integrate minor changes lost by past mistakes with git commands
There was a problem hiding this comment.
Changes look good to me Mickael.
With referecnce to the CHECK_ERR changes, I added the following to ww3_ounf in a branch that I am working on:
#define CHECK_ERR(I) CHECK_ERROR(I, __LINE__)
and renamed the subroutine to CHECK_ERROR. It saves you from having to provide specific value for ICODE in your modified subroutine, but obviously gives the line number in the pre-processed code (which is fine for debugging during development). Just thought I would mention it in case you were interested.
ok, I think we will need to upgrade the CHECK_ERR function to yours in all the WW3 codes |
|
Thanks @mickaelaccensi |
description :
bugfix for ounp string40
linked to issue #262
model :
ww3_ounp : correct missing statements for 40 characters names
matrix :
done with intel-comp/18, impi/2018.1.163, netCDF-Fortran 4.5.2
all : changes in output netcdf from string16 to string40
mww3_test_03 : not b4b known
matrix_ounp.zip