Skip to content

Conversation

@JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

remove model/esmf directory

Description

The model/esmf directory was used in early development of wmesmf. However, it is no longer being used (working to verify), so it is being removed. If you use this and need this code please comment on this PR and we can keep.

Issue(s) addressed

Related to #1488

Commit Message

remove model/esmf directory

Check list

Testing

Have not yet tested for confirmation no impacts. However, posting to get feedback for now.

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Noting here this will be open for at least 1 week if not more and we will not proceed with out @ErickRogers okay.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Based on feedback from @ErickRogers here: #1488 (comment) we can move forward with testing however we will leave this open until 9/2/2025 for comments.

@mingchen-NOAA mingchen-NOAA self-requested a review September 2, 2025 12:54
@JessicaMeixner-NOAA
Copy link
Collaborator Author

@mingchen-NOAA - This PR is ready for your testing/review.

@mingchen-NOAA
Copy link
Collaborator

I will review and test it.

@mingchen-NOAA
Copy link
Collaborator

mingchen-NOAA commented Sep 5, 2025

I have reviewed and tested this PR on Hercules Intel. No unexpected difference was observed.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompSummary.txt
matrixDiff.txt
matrixCompFull.txt

@mingchen-NOAA mingchen-NOAA merged commit 9d9e3d0 into NOAA-EMC:develop Sep 5, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants