Bugfix on -prefix and build flexibility for UPP.
#746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om anywhere. correct bug when prefix is specified, the executable is not in the correct place.
|
@aerorahul Can you open an UPP issue linking to this PR? |
|
|
@FernandoAndrade-NOAA Please conduct the UPP RT tests on Hera. There should be no changed results with this PR. |
|
The UPP RT tests were completed on WCOSS2 and Orion without changed results. |
|
UPP RTs on Hera have completed with no changes to results. |
FernandoAndrade-NOAA
approved these changes
Jul 17, 2023
WenMeng-NOAA
added
the
No Baseline Change
WenMeng-NOAA
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
-prefixis provided withcompile.sh, the executable is not placed in the right directorybuilddirectory rather than hard-wiring it in the repo source.compile.shfrom anywhere. This is used in the GFS and GEFS applicationscompile.sh.Fixes #747 #748