Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Updates #355

Merged
merged 6 commits into from
Aug 6, 2021
Merged

Documentation Updates #355

merged 6 commits into from
Aug 6, 2021

Conversation

hertneky
Copy link
Contributor

@hertneky hertneky commented Aug 2, 2021

#354 Updates to documentation to be more inline with develop

@hertneky hertneky mentioned this pull request Aug 2, 2021
Closed
@WenMeng-NOAA
Copy link
Collaborator

@hertneky All of the changes are under docs/ directory. I assume there is no need for running the UPP regression tests. Could you give the instructions of reviewing these documents in rst format online? Thanks!

@hertneky
Copy link
Contributor Author

hertneky commented Aug 6, 2021

@WenMeng-NOAA Only documentation changes were made. These can be viewed from my fork https://upp-hertneky.readthedocs.io/en/update_docs_tjh/ or do you mean some other way?

@WenMeng-NOAA
Copy link
Collaborator

@hertneky That's the link I need. When your PR merged, could you add a link of documents on a WIKI page so our UPP users can review online. Thanks!

@hertneky
Copy link
Contributor Author

hertneky commented Aug 6, 2021

@WenMeng-NOAA That is actually on my list to do in terms of wiki updates. Kate and I discussed this yesterday, to have a link to the latest (develop) and also latest community release (v9.0.0).

@WenMeng-NOAA
Copy link
Collaborator

@hertneky That would be great, Thanks!

@hertneky
Copy link
Contributor Author

hertneky commented Aug 6, 2021

@WenMeng-NOAA I added the links to the wiki. The 'latest' will update automatically when the PR is merged.

@WenMeng-NOAA
Copy link
Collaborator

@hertneky It looks good to me. Could you update your feature branch with upstream/develop? For your case, you may click "Fetch upstream" at your UPP fork. Thanks!

@hertneky
Copy link
Contributor Author

hertneky commented Aug 6, 2021

@WenMeng-NOAA Done

@WenMeng-NOAA
Copy link
Collaborator

@hertneky It looks good to me. I might wait for @fossell 's comments for final merging. Thanks!

fossell
fossell approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hertneky - This looks great, thanks for all your work on these enhancements!

@WenMeng-NOAA WenMeng-NOAA linked an issue Aug 6, 2021 that may be closed by this pull request
Documentation Updates #354
Closed
@WenMeng-NOAA
Copy link
Collaborator

There are no changed results from the UPP regression tests. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit a60325e into NOAA-EMC:develop Aug 6, 2021
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Aug 6, 2021
Closed
@fossell fossell mentioned this pull request Aug 24, 2021
Closed
@hertneky hertneky deleted the update_docs_tjh branch May 10, 2022 20:35
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@hu5970
Add BUFRSND task from EMC. (NOAA-EMC#355)
80f6533 
Copy forecast initial to NWGES.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@fossell fossell fossell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation Updates
3 participants
@hertneky @WenMeng-NOAA @fossell