Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reomve dependency on gfsio lib #338

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

WenMeng-NOAA
Copy link
Collaborator

Phase out legacy capability of reading model output in grib1 and remove dependency on gfsio lib.

@GeorgeVandenberghe-NOAA
Copy link
Contributor

@WenMeng-NOAA
Copy link
Collaborator Author

WenMeng-NOAA commented Jun 21, 2021

@GeorgeVandenberghe-NOAA You may checkout as:

git clone git@github.com:WenMeng-NOAA/EMC_post.git
cd EMC_post
git checkout post_gfsio
git submodule update --init modulefiles

@WenMeng-NOAA WenMeng-NOAA linked an issue Jun 21, 2021 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. No changed results were found.

@GeorgeVandenberghe-NOAA
Copy link
Contributor

@WenMeng-NOAA
Copy link
Collaborator Author

@GeorgeVandenberghe-NOAA Thanks for verifying on jet.

Copy link
Collaborator

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thank you.

@HuiyaChuang-NOAA
Copy link
Collaborator

Thank you, @WenMeng-NOAA @GeorgeVandenberghe-NOAA

@WenMeng-NOAA WenMeng-NOAA merged commit f7874cb into NOAA-EMC:develop Jun 21, 2021
@WenMeng-NOAA WenMeng-NOAA deleted the post_gfsio branch October 5, 2021 12:27
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
add POST_SUB_MODEL_NAME to match the latest UPP code
smart file name prefix for final wgrib2 products
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on gfsio lib
3 participants