Output pratemax from UPP #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericaligo-NOAA Do you have the sample of history files including pratemax so I can conduct the UPP standalone test. Thanks! |
|
Sure, there is also a 507. Should I put it after 507?
…On 6/11/2021 4:02 PM, WenMeng-NOAA wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In parm/post_avblflds.xml
<#332 (comment)>:
> @@ -1482,6 +1482,17 @@
<scale>3.0</scale>
</param>
+ <param>
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> Can you move this
new entries of 508 after the definition of 506?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75ML3G6JDWYRKGXU37TTTSJTWVANCNFSM46RKM6NA>.
|
That's right. Sorry for my typo. |
|
/scratch2/NCEPDEV/fv3-cam/noscrub/Eric.Aligo/2020030212/fv3_sar_thompson_mynn_mynn_pratemax_rain.
In this directory, I also ran the inline post, and you'll see pratemax
in those grib2 files.
Eric
…On 6/11/2021 4:05 PM, WenMeng-NOAA wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> Do you have the
sample of history files including pratemax so I can conduct the UPP
standalone test. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MM6NBF52U76GNJ5VA3TSJUCFANCNFSM46RKM6NA>.
|
|
Changed and pushed to branch.
…On 6/11/2021 4:19 PM, WenMeng-NOAA wrote:
Sure, there is also a 507. Should I put it after 507?
… <#>
On 6/11/2021 4:02 PM, WenMeng-NOAA wrote: ***@***.***
<https://github.com/WenMeng-NOAA>/ commented on this pull request.
------------------------------------------------------------------------
In parm/post_avblflds.xml <#332 (comment)
<#332 (comment)>>:
> @@ -1482,6 +1482,17 @@ 3.0 + @ericaligo-NOAA
<https://github.com/ericaligo-NOAA>
https://github.com/ericaligo-NOAA
<https://github.com/ericaligo-NOAA> Can you move this new entries
of 508 after the definition of 506? — You are receiving this
because you were mentioned. Reply to this email directly, view it
on GitHub <#332 (review)
<#332 (review)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQ75ML3G6JDWYRKGXU37TTTSJTWVANCNFSM46RKM6NA
<https://github.com/notifications/unsubscribe-auth/ALQ75ML3G6JDWYRKGXU37TTTSJTWVANCNFSM46RKM6NA>.
That's right. Sorry for my typo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MNMV6THJZZOXXE6AELTSJVWVANCNFSM46RKM6NA>.
|
|
@ericaligo-NOAA Now your PR looks good to me. I will start the UPP tests soon. Thanks! |
|
@ericaligo-NOAA It seems to me, pratemax is inquired by hafs xml file postcntrl_hafs.xml. When the definition of pratemax is added in post_avblflds.xml, |
|
Done!
…On 6/11/2021 5:06 PM, WenMeng-NOAA wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> It seems to me,
pratemax is inquired by hafs xml file postcntrl_hafs.xml. When the
definition of pratemax is added in post_avblflds.xml,
the pratemax is available in hafs flat file postxconfig-NT-hafs.txt.
You may run "make" under parm/ to verify it. Can you commit
postxconfig-NT-hafs.txt in your branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MNYBNVPV7XVULWAIF3TSJ3GVANCNFSM46RKM6NA>.
|
|
@ericaligo-NOAA One more update is needed. Can you update the file EMC_post/VERSION with 10.0.8 in your branch feature/pratemax? Thanks! |
|
Done.
…On 6/14/2021 10:30 AM, WenMeng-NOAA wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> One more update is
needed. Can you update the file EMC_post/VERSION with 10.0.8 in your
branch feature/pratemax? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MPQQTWYSEWUJCYYSXTTSYG7JANCNFSM46RKM6NA>.
|
WenMeng-NOAA
approved these changes
Jun 14, 2021
|
The UPP standalone tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. With this PR updated, the baselines for fv3lam and hafs will be re-created. This PR is ready for merging. |
|
Wen, may I ask when the UPP lib will be updated with pratemax output? On
the model side, Eric's PR is planned for tomorrow as he is going to take
leave on 6 17/18. We may need another PR to update UPP lib after his commit
as we were told the regional applications should have the pratemax from
model inline post by 6/21. Thanks.
…On Mon, Jun 14, 2021 at 11:14 AM WenMeng-NOAA ***@***.***> wrote:
The UPP standalone tests were conducted on WCOSS-Dell, WCOSS-Cray and
Hera. With this PR updated, the baselines for fv3lam and hafs will be
re-created. This PR is ready for merging.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPID4VLLPTOPRALDZLTSYLIZANCNFSM46RKM6NA>
.
|
|
@junwang-noaa I will do code handoff for upp/10.0.8 installation at the hpc-stack soon. Updating upp lib and the changes of the control files for inline post in another PR at ufs-weather-model side i is working to me. Please let me how you will start the new PR. Thanks! |
|
Jun,
The upp/10.0.8 is available on WCOSS-Dell, WCOSS-Cray and Hera. Please let
me know how you would like to proceed the updates at ufs-weather-model side.
Thanks,
Wen
…On Mon, Jun 14, 2021 at 11:23 AM Jun Wang ***@***.***> wrote:
Wen, may I ask when the UPP lib will be updated with pratemax output? On
the model side, Eric's PR is planned for tomorrow as he is going to take
leave on 6 17/18. We may need another PR to update UPP lib after his commit
as we were told the regional applications should have the pratemax from
model inline post by 6/21. Thanks.
On Mon, Jun 14, 2021 at 11:14 AM WenMeng-NOAA ***@***.***>
wrote:
> The UPP standalone tests were conducted on WCOSS-Dell, WCOSS-Cray and
> Hera. With this PR updated, the baselines for fv3lam and hafs will be
> re-created. This PR is ready for merging.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#332 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AI7D6TPID4VLLPTOPRALDZLTSYLIZANCNFSM46RKM6NA
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQGNET2ZJ6LBWWUDLUS3HDTSYNFPANCNFSM46RKM6NA>
.
--
Wen Meng
IMSG at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Room 2070
College Park, MD 20740
***@***.***
301-683-3779
|
|
Wen, please make a PR to ufs-weather-model (create a branch from
ufs-weather-model, update those post related files under
ufs-weather-model/tests/parm, and update the upp/g2tmpl module in
ufs-weather-model/modulefiles/ufs_common(and ufs_common_debug). Then you
can make a PR from your branch. Thanks.
On Tue, Jun 15, 2021 at 8:16 AM WenMeng-NOAA ***@***.***>
wrote:
… Jun,
The upp/10.0.8 is available on WCOSS-Dell, WCOSS-Cray and Hera. Please let
me know how you would like to proceed the updates at ufs-weather-model
side.
Thanks,
Wen
On Mon, Jun 14, 2021 at 11:23 AM Jun Wang ***@***.***> wrote:
> Wen, may I ask when the UPP lib will be updated with pratemax output? On
> the model side, Eric's PR is planned for tomorrow as he is going to take
> leave on 6 17/18. We may need another PR to update UPP lib after his
commit
> as we were told the regional applications should have the pratemax from
> model inline post by 6/21. Thanks.
>
> On Mon, Jun 14, 2021 at 11:14 AM WenMeng-NOAA ***@***.***>
> wrote:
>
> > The UPP standalone tests were conducted on WCOSS-Dell, WCOSS-Cray and
> > Hera. With this PR updated, the baselines for fv3lam and hafs will be
> > re-created. This PR is ready for merging.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <#332 (comment)
>,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AI7D6TPID4VLLPTOPRALDZLTSYLIZANCNFSM46RKM6NA
> >
> > .
> >
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#332 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ALQGNET2ZJ6LBWWUDLUS3HDTSYNFPANCNFSM46RKM6NA
>
> .
>
--
Wen Meng
IMSG at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Room 2070
College Park, MD 20740
***@***.***
301-683-3779
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKJTPR3NOOTR4KBJNDTS5ACZANCNFSM46RKM6NA>
.
|
|
Sure. I will do it and might need further guidance from you.
Thanks,
Wen
…On Tue, Jun 15, 2021 at 8:29 AM Jun Wang ***@***.***> wrote:
Wen, please make a PR to ufs-weather-model (create a branch from
ufs-weather-model, update those post related files under
ufs-weather-model/tests/parm, and update the upp/g2tmpl module in
ufs-weather-model/modulefiles/ufs_common(and ufs_common_debug). Then you
can make a PR from your branch. Thanks.
On Tue, Jun 15, 2021 at 8:16 AM WenMeng-NOAA ***@***.***>
wrote:
> Jun,
>
> The upp/10.0.8 is available on WCOSS-Dell, WCOSS-Cray and Hera. Please
let
> me know how you would like to proceed the updates at ufs-weather-model
> side.
>
> Thanks,
>
> Wen
>
> On Mon, Jun 14, 2021 at 11:23 AM Jun Wang ***@***.***> wrote:
>
> > Wen, may I ask when the UPP lib will be updated with pratemax output?
On
> > the model side, Eric's PR is planned for tomorrow as he is going to
take
> > leave on 6 17/18. We may need another PR to update UPP lib after his
> commit
> > as we were told the regional applications should have the pratemax from
> > model inline post by 6/21. Thanks.
> >
> > On Mon, Jun 14, 2021 at 11:14 AM WenMeng-NOAA ***@***.***>
> > wrote:
> >
> > > The UPP standalone tests were conducted on WCOSS-Dell, WCOSS-Cray and
> > > Hera. With this PR updated, the baselines for fv3lam and hafs will be
> > > re-created. This PR is ready for merging.
> > >
> > > —
> > > You are receiving this because you are subscribed to this thread.
> > > Reply to this email directly, view it on GitHub
> > > <
#332 (comment)
> >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/AI7D6TPID4VLLPTOPRALDZLTSYLIZANCNFSM46RKM6NA
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you modified the open/close state.
> > Reply to this email directly, view it on GitHub
> > <#332 (comment)
>,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ALQGNET2ZJ6LBWWUDLUS3HDTSYNFPANCNFSM46RKM6NA
> >
> > .
> >
>
>
> --
> Wen Meng
> IMSG at NOAA/NWS/NCEP/EMC
> 5830 University Research Ct., Room 2070
> College Park, MD 20740
> ***@***.***
> 301-683-3779
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#332 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AI7D6TKJTPR3NOOTR4KBJNDTS5ACZANCNFSM46RKM6NA
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQGNEVGCI66XOZS7V2EGADTS5BTFANCNFSM46RKM6NA>
.
--
Wen Meng
IMSG at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Room 2070
College Park, MD 20740
***@***.***
301-683-3779
|
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
…-EMC#332) * Add if statement in set_thompson_mp_fix_files.sh to source Thompson climo file when using a combination of a Thompson-based SDF and non-RAP/HRRR external model data * Modify if statement based on external models for Thompson climo file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are:
Issue:
#331