Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in initializing post fields and checking undefined points in visibility computation. #324

Merged
merged 2 commits into from
May 27, 2021

Conversation

WenMeng-NOAA
Copy link
Collaborator

The main changes are:

  1. Bug fix in ALLOCATE_ALL.f
  2. Add checking of undefined points in CALVIS_GSD.f and CALVIS.f

@WenMeng-NOAA WenMeng-NOAA linked an issue May 27, 2021 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. With this PR merging, the baseline of nmmb will
be re-created for GSD visibility change.

@WenMeng-NOAA WenMeng-NOAA merged commit 065e2fa into NOAA-EMC:develop May 27, 2021
@GeorgeVandenberghe-NOAA
Copy link
Contributor

GeorgeVandenberghe-NOAA commented May 29, 2021

This appears to have fixed the reproducibility issue in the WRF regression tests, at least on Jet where I reran them

@HuiyaChuang-NOAA
Copy link
Collaborator

This appears to have fixed the reproducibility issue in the WRF regression tests, at least on Jet where I reran them

Great! thanks for the report

@GeorgeVandenberghe-NOAA
Copy link
Contributor

GeorgeVandenberghe-NOAA commented Jun 1, 2021 via email

@WenMeng-NOAA WenMeng-NOAA deleted the post_allocate_im branch October 5, 2021 12:26
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
* update the FIX_RRFS location at WCOSS

* update testbed_fields_rtma.txt and config.sh.RTMA_CONUS_3km
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indexing in ALLOCATE_ALL.f
4 participants