Update/generalize paths for GFSv17 COM reorg #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming update to GFS v17 will substantially change the COM paths
for the GFS package. When called within global workflow, `$COMINgfs` now
contains the full path to the desired directories. This requires changes
to how the look-behind and look-ahead are done. Now instead of constructing
the path itself, the lookbehind and look-ahead now do a substitution of
`${PDY}/${cyc}` with the new desired values for the other cycles.
Additional changes will be needed to the j-jobs to match the updated
`$COMINgfs` pattern for GFS v17 in order to run this as a seperate system
(as in ops). Also, not all GFS tracker jobs are currently available in the
global workflow, so changes for FSU genesis have not been tested.
Additional changes will also be needed for GEFS v13, which is making similar
changes to COM.
Refs: NOAA-EMC#1
Refs: NOAA-EMC/global-workflow#761
WalterKolczynski-NOAA
requested review from
KateFriedman-NOAA and
JiayiPeng-NOAA
|
Hi Walter,
With the COMINgfs/COMINgefs changes, the TC track/genesis package will be
updated. I will test and make a new TAG for this update.
Thanks,
Jiayi
…On Mon, Apr 10, 2023 at 3:48 PM Walter Kolczynski - NOAA < ***@***.***> wrote:
The upcoming update to GFS v17 will substantially change the COM paths for
the GFS package. When called within global workflow, $COMINgfs now
contains the full path to the desired directories. This requires changes to
how the look-behind and look-ahead are done. Now instead of constructing
the path itself, the lookbehind and look-ahead now do a substitution of
${PDY}/${cyc} with the new desired values for the other cycles.
Additional changes will be needed to the j-jobs to match the updated
$COMINgfs pattern for GFS v17 in order to run this as a seperate system
(as in ops). Also, not all GFS tracker jobs are currently available in the
global workflow, so changes for FSU genesis have not been tested.
Additional changes will also be needed for GEFS v13, which is making
similar changes to COM.
Refs: #1 <#1>
Refs: NOAA-EMC/global-workflow#761
<NOAA-EMC/global-workflow#761>
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- b4e6480
<b4e6480>
Update/generalize paths for GFSv17 COM reorg
File Changes
(4 files <https://github.com/NOAA-EMC/TC_tracker/pull/2/files>)
- *M* scripts/exgfs_tc_genesis.sh
<https://github.com/NOAA-EMC/TC_tracker/pull/2/files#diff-86fa2f9bab34bb8276b135a931c9e587e86241052e5af58b2b0f194096d73070>
(2)
- *M* ush/extrkr_fsu.sh
<https://github.com/NOAA-EMC/TC_tracker/pull/2/files#diff-326a978f4bf9538e5063810015804951d61c76c63e84637379b43aa71de89152>
(4)
- *M* ush/extrkr_gfs.sh
<https://github.com/NOAA-EMC/TC_tracker/pull/2/files#diff-d832085a36776c6f732302052954417c5d4ff87e62d678f0f759ead9001ffa8c>
(8)
- *M* ush/extrkr_tcv_gfs.sh
<https://github.com/NOAA-EMC/TC_tracker/pull/2/files#diff-271b816fc63f6d6df00838409b5cd905533fb6aa184cab330500bfec467c49b3>
(8)
Patch Links:
- https://github.com/NOAA-EMC/TC_tracker/pull/2.patch
- https://github.com/NOAA-EMC/TC_tracker/pull/2.diff
—
Reply to this email directly, view it on GitHub
<#2>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRTVNKMEE3XU277CFMHT3DXARPXBANCNFSM6AAAAAAWZK6R5A>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
17 tasks
@JiayiPeng-NOAA Please cut a new tag with the Jet updates before ingesting the COM reorg updates. Thanks! |
|
Hi Kate,
I Agree.
I will make this version/TAG working for Wcoss2/Jet/Hera/Orion, and another
TAG to adopt COMINgfs/COMINgefs changes.
Thanks,
Jiayi
…On Tue, Apr 11, 2023 at 1:32 PM Kate Friedman ***@***.***> wrote:
Hi Walter, With the COMINgfs/COMINgefs changes, the TC track/genesis
package will be updated. I will test and make a new TAG for this update.
Thanks, Jiayi
@JiayiPeng-NOAA <https://github.com/JiayiPeng-NOAA> Please cut a new tag
with the Jet updates before ingesting the COM reorg updates. Thanks!
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRTVNOSFD376MSYAAHY4Q3XAWIRNANCNFSM6AAAAAAWZK6R5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Perfect, thanks @JiayiPeng-NOAA ! |
KateFriedman-NOAA
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Look good and work. Up to @JiayiPeng-NOAA to approve further.
|
@JiayiPeng-NOAA What happened with this PR? |
|
Hi Walter,
Please go ahead to close this PR.
Thanks,
Jiayi
…On Mon, Oct 23, 2023 at 6:17 AM Walter Kolczynski - NOAA < ***@***.***> wrote:
@JiayiPeng-NOAA <https://github.com/JiayiPeng-NOAA> What happened with
this PR?
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRTVNPTAOKOPWHKMRJJQOTYAY74NAVCNFSM6AAAAAAWZK6R5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHA3TCMZZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@JiayiPeng-NOAA Okay, should I open a new one for the current develop? We do need to get these updates in. |
|
Hi Walter,
What updates do you have?
Structure changes? and /or module/library changes?
Thanks,
Jiayi
…On Mon, Oct 23, 2023 at 1:21 PM Walter Kolczynski - NOAA < ***@***.***> wrote:
@JiayiPeng-NOAA <https://github.com/JiayiPeng-NOAA> Okay, should I open a
new one for the current develop? We do need to get these updates in.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRTVNPJEUR2SZ6WL42IYSLYA2RPZAVCNFSM6AAAAAAWZK6R5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGY3DCOJTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The updates that were in this PR. Just path changes, but they require a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming update to GFS v17 will substantially change the COM paths for the GFS package. When called within global workflow,
$COMINgfsnow contains the full path to the desired directories. This requires changes to how the look-behind and look-ahead are done. Now instead of constructing the path itself, the lookbehind and look-ahead now do a substitution of${PDY}/${cyc}with the new desired values for the other cycles.Additional changes will be needed to the j-jobs to match the updated
$COMINgfspattern for GFS v17 in order to run this as a seperate system (as in ops). Also, not all GFS tracker jobs are currently available in the global workflow, so changes for FSU genesis have not been tested.Additional changes will also be needed for GEFS v13, which is making similar changes to COM.
Refs: #1
Refs: NOAA-EMC/global-workflow#761