Support png bit depths 1, 2 and 4 #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you will get the missing test runs when you merge in the develp branch. These look like good changes, and thanks a lot for the tests! Let me know when this is ready to merge. |
|
@webisu Do you want to test this branch with wgrib2 to see if png with 1, 2 and 4 bit depths works as expected? |
|
Wgrib2 doesn't use g2c right now.
…On Tue, Oct 8, 2024 at 11:51 AM Dusan Jovic ***@***.***> wrote:
@webisu <https://github.com/webisu> Do you want to test this branch with
wgrib2 to see if png with 1, 2 and 4 bit depths works as expected?
—
Reply to this email directly, view it on GitHub
<#526 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIB7ZSW3TMIVAXNBHR7AVTZ2P5PRAVCNFSM6AAAAABPKJSUD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGIZDCNBSG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
However, wgrib2 is about to start using g2c for compression. @DusanJovic-NOAA I suggest that if this passes your tests we merge it and it can be tested further with wgrib2 later. |
…cmake.in When this library is compiled as a submodule of another project the location of PackageConfig.cmake.in template file must be specifield using this project's source directory (PROJECT_SOURCE_DIR) not the parent project's (top-level) source directory (CMAKE_SOURCE_DIR)
edwardhartnett
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update png pack/unpack and encode/decode routines to support bit depths 1, 2 and 4.
Fixes #508