Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marine obs reorganization and more ... #876

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

guillaumevernieres
Copy link
Contributor

Things done:

  • Assumes that the obs will be organized like something like this from now on:
└── gdas.20180415
    └── 12
        └── ocean
            ├── adt
            │   ├── rads_adt_3a_2018105.nc
            │   └── rads_adt_3b_2018105.nc
            ├── icec
            │   ├── AMSR2-SEAICE-NH_v2r2_GW1_s201804150835180_e201804151014170_c201804151052280.nc
            │   ├── AMSR2-SEAICE-NH_v2r2_GW1_s201804151014190_e201804151150170_c201804151309570.nc
            │   ├── AMSR2-SEAICE-SH_v2r2_GW1_s201804150835180_e201804151014170_c201804151052280.nc
            │   └── AMSR2-SEAICE-SH_v2r2_GW1_s201804151014190_e201804151150170_c201804151309570.nc
            ├── sss
            └── sst
                ├── 20180415095000-STAR-L3U_GHRSST-SSTsubskin-AVHRRF_MB-ACSPO_V2.80-v02.0-fv01.0.nc
                ├── 20180415114000-STAR-L3U_GHRSST-SSTsubskin-AVHRRF_MB-ACSPO_V2.80-v02.0-fv01.0.nc
                └── 20180415132000-STAR-L3U_GHRSST-SSTsubskin-AVHRRF_MB-ACSPO_V2.80-v02.0-fv01.0.nc
  • Use of the * wildcard instead of ? to simplify the obs file selection
  • Addition of binning for the sst retrieval
  • The soca # needs to be more recent.
  • This wasn't planned as part of this work, but the bump localization was having issues, so I replaced it with diffusion

Issues addressed

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jan 25, 2024
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 25, 2024
@emcbot
Copy link

emcbot commented Jan 25, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Jan 25 12:19:30 CST 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Thu Jan 25 12:34:58 CST 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/876/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jan 25, 2024
@emcbot
Copy link

emcbot commented Jan 25, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Jan 25 18:31:29 UTC 2024 on hfe07
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Thu Jan 25 18:44:35 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/876/global-workflow/sorc/log.build

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 25, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Jan 25, 2024
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 25, 2024
@emcbot
Copy link

emcbot commented Jan 25, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Jan 25 14:45:38 CST 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Thu Jan 25 15:14:44 CST 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/876/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jan 25, 2024
@emcbot
Copy link

emcbot commented Jan 25, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Jan 25 20:47:19 UTC 2024 on hfe07
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Thu Jan 25 21:24:53 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/876/global-workflow/sorc/log.build

@emcbot emcbot removed the hera-GW-RT-Running Automated testing with global-workflow running on Hera label Jan 25, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jan 26, 2024
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 26, 2024
@emcbot
Copy link

emcbot commented Jan 26, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Jan 26 14:45:32 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Jan 26 14:59:19 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Jan 26 15:32:22 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 52

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 26, 2024
@guillaumevernieres guillaumevernieres marked this pull request as ready for review January 26, 2024 15:42
@emcbot
Copy link

emcbot commented Jan 26, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Jan 26 08:45:36 CST 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Jan 26 09:01:29 CST 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Jan 26 09:42:24 CST 2024
Tests: 100% tests passed, 0 tests failed out of 52

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jan 26, 2024
@AndrewEichmann-NOAA
Copy link
Collaborator

@guillaumevernieres I'm refactoring the obsprep_setup, so don't sweat that too much

@guillaumevernieres
Copy link
Contributor Author

@RussTreadon-NOAA , @CoryMartin-NOAA , FYI: I added an update to the # commit of the JEDI repositories.

@CoryMartin-NOAA
Copy link
Contributor

Just a question: Is this the assumed structure for DMPDIR, COM_OBS, or both?

@guillaumevernieres
Copy link
Contributor Author

Just a question: Is this the assumed structure for DMPDIR, COM_OBS, or both?

@CoryMartin-NOAA , what's in the description is the assumed structure of DMPDIR.

@CoryMartin-NOAA
Copy link
Contributor

Thanks, @guillaumevernieres !

@guillaumevernieres guillaumevernieres merged commit 5549447 into develop Jan 26, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/marine-obs-reorg branch March 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JEDI #'s Regexp to select the marine obs is too restrictive
6 participants