Skip to content

Update marine ensemble recentering to do increment QC as in v17 - #2210

Draft
shlyaeva wants to merge 1 commit into
developfrom
feature/marine_ens_qc
Draft

Update marine ensemble recentering to do increment QC as in v17#2210
shlyaeva wants to merge 1 commit into
developfrom
feature/marine_ens_qc

Conversation

@shlyaeva

Copy link
Copy Markdown
Collaborator

Description

Adding bounds checks, steric height check and coastal increment filter to the marine ensemble recentering, as in v17 (NOAA-EMC/jcb-gdas#232)

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_ufsgsi_hybatmDA
  • C48_ufsenkf_atmDA
  • C96C48_hybatmDA

@emcbot

emcbot commented Aug 13, 2026

Copy link
Copy Markdown

Automated GW-GDASApp Testing Results:
Machine: ursa

Start: Thu Aug 13 15:02:01 UTC 2026 on ufe01
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Aug 13 15:14:53 UTC 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_ufsgsi_hybatmDA|C96C48_hybatmsnowDA|C96_gcafs_cycled|C48_ufsenkf_atmDA|C48mx500_3DVarAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Thu Aug 13 15:37:12 UTC 2026
Tests: 100% tests passed, 0 tests failed out of 20

sea_water_potential_temperature: [-2.5, 36.0]
sea_water_salinity: [0.0, 44.0]

absolute steric increment max: 0.5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should skip the use of the steric height and coastal increment filters and keep the develop branch as free from my ductaping as possible. Also, I don't think the coastal increment filter is needed any more after your various updates to "soca2cice". Maybe we comment them out and add a comment suggesting to maybe revisit when we start applying the LETKF increment? Ideally we don't want these things turned on.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm going to put this to draft for now then. I am starting to experiment with LETKF, which is why I wanted to turn this on, but I'll try first with only the bounds checks.

@shlyaeva
shlyaeva marked this pull request as draft August 13, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants