Update marine ensemble recentering to do increment QC as in v17 - #2210
Draft
shlyaeva wants to merge 1 commit into
Draft
Update marine ensemble recentering to do increment QC as in v17#2210shlyaeva wants to merge 1 commit into
shlyaeva wants to merge 1 commit into
Conversation
|
Automated GW-GDASApp Testing Results: |
| sea_water_potential_temperature: [-2.5, 36.0] | ||
| sea_water_salinity: [0.0, 44.0] | ||
|
|
||
| absolute steric increment max: 0.5 |
Contributor
There was a problem hiding this comment.
We should skip the use of the steric height and coastal increment filters and keep the develop branch as free from my ductaping as possible. Also, I don't think the coastal increment filter is needed any more after your various updates to "soca2cice". Maybe we comment them out and add a comment suggesting to maybe revisit when we start applying the LETKF increment? Ideally we don't want these things turned on.
Collaborator
Author
There was a problem hiding this comment.
OK, I'm going to put this to draft for now then. I am starting to experiment with LETKF, which is why I wanted to turn this on, but I'll try first with only the bounds checks.
shlyaeva
marked this pull request as draft
August 13, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding bounds checks, steric height check and coastal increment filter to the marine ensemble recentering, as in v17 (NOAA-EMC/jcb-gdas#232)
Automated CI tests to run in Global Workflow