-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completes LETKF task, adds WCDA CI test #1287
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
parm/soca/letkf/letkf_save.yaml.j2
Outdated
{% set COMOUT_ICE_LETKF_MEM = COM_ICE_LETKF_TMPL | replace_tmpl(tmpl_dict) %} | ||
|
||
- ["{{ DATA }}/Data/ocn.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_OCEAN_LETKF_MEM }}/{{ RUN }}.ocean.t{{ cyc }}z.letkf.nc"] | ||
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.letkf.nc"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.letkf.nc"] | |
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.analysis.nc"] |
parm/soca/letkf/letkf_save.yaml.j2
Outdated
|
||
- ["{{ DATA }}/Data/ocn.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_OCEAN_LETKF_MEM }}/{{ RUN }}.ocean.t{{ cyc }}z.letkf.nc"] | ||
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.letkf.nc"] | ||
{% endfor %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No EOL
@@ -1,4 +1,3 @@ | |||
# TODO(AFE): make resolution dependent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these not made resolution dependent? Seems like a lot of redundancy here that can be simplified with some Jinja
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got broken out into different yamls - @guillaumevernieres is there a particular approach you're committed to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the one that we have now. We might decide to combine these at some point, but it's pretty far down the priority list.
Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
@@ -17,6 +17,13 @@ obs operator: | |||
name: ADT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you removed the halo distribution, does the LETKF observer work without the halo distribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets inserted dynamically in the script until the obs config files get jinjafied
Completes LETKF task, adds WCDA CI test
Mutually dependent on NOAA-EMC/global-workflow#2944