Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes LETKF task, adds WCDA CI test #1287

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Completes LETKF task, adds WCDA CI test

Mutually dependent on NOAA-EMC/global-workflow#2944

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test/gw-ci/CMakeLists.txt Outdated Show resolved Hide resolved
parm/soca/letkf/letkf.yaml.j2 Outdated Show resolved Hide resolved
parm/soca/letkf/letkf.yaml.j2 Outdated Show resolved Hide resolved
parm/soca/letkf/letkf_save.yaml.j2 Outdated Show resolved Hide resolved
{% set COMOUT_ICE_LETKF_MEM = COM_ICE_LETKF_TMPL | replace_tmpl(tmpl_dict) %}

- ["{{ DATA }}/Data/ocn.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_OCEAN_LETKF_MEM }}/{{ RUN }}.ocean.t{{ cyc }}z.letkf.nc"]
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.letkf.nc"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.letkf.nc"]
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.analysis.nc"]


- ["{{ DATA }}/Data/ocn.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_OCEAN_LETKF_MEM }}/{{ RUN }}.ocean.t{{ cyc }}z.letkf.nc"]
- ["{{ DATA }}/Data/ice.letkf.ens.{{ mem }}.{{ timestr }}.PT3H.nc", "{{ COMOUT_ICE_LETKF_MEM }}/{{ RUN }}.ice.t{{ cyc }}z.letkf.nc"]
{% endfor %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No EOL

parm/soca/obs/config/sst_viirs_npp_l3u.yaml Outdated Show resolved Hide resolved
@@ -1,4 +1,3 @@
# TODO(AFE): make resolution dependent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these not made resolution dependent? Seems like a lot of redundancy here that can be simplified with some Jinja

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got broken out into different yamls - @guillaumevernieres is there a particular approach you're committed to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the one that we have now. We might decide to combine these at some point, but it's pretty far down the priority list.

test/gw-ci/CMakeLists.txt Outdated Show resolved Hide resolved
test/gw-ci/CMakeLists.txt Outdated Show resolved Hide resolved
test/gw-ci/CMakeLists.txt Outdated Show resolved Hide resolved
@@ -17,6 +17,13 @@ obs operator:
name: ADT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you removed the halo distribution, does the LETKF observer work without the halo distribution?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets inserted dynamically in the script until the obs config files get jinjafied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants