PR to use 3-digit evs_ver, use $MAILTO, remove pgmout, etc ...

[ShelleyMelchior-NOAA]

Pull Request Testing

• Describe testing already performed for this Pull Request:
  
  This PR updates evs_ver to be 3-digits. Impacted files are verisons/run.ver and all files in dev/drivers/scripts/
  This PR removes the sorc/ script that built the symlink to the fix/ directory.
  This PR removes any lingering instances of pgmout.
  This PR replaces $maillist w/ the NCO Table 1 variable, $MAILTO.
  This PR moves modulefiles/ to dev/modulefiles/. Impacted files are all files in dev/drivers/scripts/

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Testing should include random selection of components for all 3 steps to assure EVS-wide impact is not harmful.
  I also suggest one end-to-end test for all 3 (or 2) steps in a single component.

• Has the code been checked to ensure that no errors occur during the execution? [Yes or No]

• Do these updates/additions include sufficient testing updates? [Yes or No]

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

• Review the source issue metadata (required labels, projects, and milestone).

• Complete the PR description above.

• Ensure the PR title matches the feature branch name.

• Check the following:

• Instructions provided on how to run

• Developer's name is replaced by ${user} where necessary throughout the code

• Check that the ecf file has all the proper definitions of variables

• Check that the jobs file has all the proper settings of COMIN and COMOUT and other input variables

• Check to see that the output directory structure is followed

• Be sure that you are not using MET utilities outside the METplus wrapper structure

• After submitting the PR, select Development issue with the original issue number.

• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.

• Close the linked issue.

[ShelleyMelchior-NOAA]

Ok. I see what happened. The export evs_ver=v1.0.0 got reintroduced in some components when I merged in develop after PRs were merged. I also see that build.ver still uses the 2-digit version for evs_ver. Let me take care of that clean up.

[PerryShafran-NOAA]

@ShelleyMelchior-NOAA Will I need to re-run what's been done above?

[ShelleyMelchior-NOAA]

There were many components where export evs_ver snuck back into the drivers. I would retest prep, maybe choose a different component this time.

I also just made changes to make sure no more $maillist vars snuck back in.

[AliciaBentley-NOAA]

@PerryShafran-NOAA @ShelleyMelchior-NOAA Since build.ver was changed, can we also compile and test something with this PR?

[PerryShafran-NOAA]

@AliciaBentley-NOAA excellent idea! I'll do the global_det prep, which I believe uses a lot of these codes.

[PerryShafran-NOAA]

@ShelleyMelchior-NOAA The global_det prep step completed, and looked like the executables are all OK. See /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr354test/EVS/dev/drivers/scripts/prep/global_det/jevs_global_det_atmos_prep_00.o93488665. But you will see WARNINGs due to missing files, but that's also because I'm running too early to catch some stuff that comes in later. I'm doing a re-run with PDYm2.

Also see the output directory /lfs/h2/emc/vpppg/noscrub/perry.shafran/evs/v1.0/prep/global_det/atmos.20231116

Feel that in general this step worked pretty well as intended.

[ShelleyMelchior-NOAA]

Thanks Perry. global_det prep seems OK. ✔️

[PerryShafran-NOAA]

@ShelleyMelchior-NOAA Good news! I made Marcel's suggested change to the analysis plot job, and it changed the word ERROR to WARNING.

If you want to add this change, please grab my file and add to this branch:

/lfs/h2/emc/vpppg/noscrub/perry.shafran/pr354test/EVS/ush/analyses/df_preprocessing.py

And also you may validate:

The .o file is here:

/lfs/h2/emc/vpppg/noscrub/perry.shafran/pr354test/EVS/dev/drivers/scripts/plots/analyses/jevs_analyses_grid2obs_plots.o93490085

And the plot tarball is here:

/lfs/h2/emc/vpppg/noscrub/perry.shafran/evs/v1.0/plots/analyses/atmos.20231115

Not sure why this wound up in noscrub? The plots are going to ptmp in the emc.vpppg correctly. Anyway, here you go....

[PerryShafran-NOAA]

I made the updates directly into your code.

[PerryShafran-NOAA]

We have determined that emails are being sent using the mailto feature, by running a job and choosing a date that doesn't have any current data in production.

I also did an nfcens test, since that's what was just merged in. That looks good too.

We may be ready to merge!

[PerryShafran-NOAA]

@ShelleyMelchior-NOAA Thanks for making those fixes! I think we are ok for merge, yes?

@AliciaBentley-NOAA

[AliciaBentley-NOAA]

@PerryShafran-NOAA I think this is ready to merge, yes! @ShelleyMelchior-NOAA can confirm.

[ShelleyMelchior-NOAA]

I approve this PR for merge. ✔️

[PerryShafran-NOAA]

Approved for merge.