This one might be the most delicate change, since it is actually affecting how we build the package.
However, we should just test once making a pseudo-tag locally (that is a proper tag, but avoiding pushing it) and building with pip wheel (that should be what we should use in the workflow, but we are not).
https://github.com/NNPDF/workflows/blob/818e8d74406df7c51992ea3b9377441a401a7087/.github/workflows/python-poetry-pypi.yml#L66-L69
So, updating the workflow with pip wheel (that should keep working for Poetry as well) is a requirement for merging this.
Originally posted by @alecandido in #189 (comment)
This one might be the most delicate change, since it is actually affecting how we build the package.
However, we should just test once making a pseudo-tag locally (that is a proper tag, but avoiding pushing it) and building with
pip wheel(that should be what we should use in the workflow, but we are not).https://github.com/NNPDF/workflows/blob/818e8d74406df7c51992ea3b9377441a401a7087/.github/workflows/python-poetry-pypi.yml#L66-L69
So, updating the workflow with
pip wheel(that should keep working for Poetry as well) is a requirement for merging this.Originally posted by @alecandido in #189 (comment)