Added Layout.CreateFromString with throwConfigExceptions parameter

[snakefoot]

Trying to prevent cases where people globally enabled LogManager.ThrowExceptions to perform Layout-validation. See also:

elmahio/elmah.io.nlog@f26377e

And moved FuncLayoutRenderer-tests to SimpleLayoutParserTests.

Could also be convinced to rename it to TryCreateFromString. But then I'm not allowed to throw exception with reason why (and where) it failed.

[304NotModified]

Could also be convinced to rename it to TryCreateFromString. But then I'm not allowed to throw exception with reason why (and where) it failed.

I prefer the TryCreateFromString (bool return, out parameter) + CreateFromString (which throws always an exception - in an error case ;).

It's really how MS is doing things and a "throw exception flag" is a known code smell AFAIK.

The only reason for not use the try-pattern is consistency which the current API (not the case I think).

So I vote for TryCreateFromString+CreateFromString :)

[snakefoot]

Since CreateFromString is a new method, then we can change the contract so it throws on error. No problem with that. If that is what you mean?

But then I don't really need TryCreateFromString unless you suggest a contract where it can return false, but still return SimpleLayout-object?

[304NotModified]

Since CreateFromString is a new method, then we can change the contract so it throws on error. No problem with that. If that is what you mean?

Yes indeed.

But then I don't really need TryCreateFromString unless you suggest a contract where it can return false, but still return SimpleLayout-object?

Not for this case indeed. But I like it as it's easier to use from the client. (no need to do a catch).

[snakefoot]

Ok what method should you call to get the default behavior where SimpleLayout replaces unknown renderers with literals ?

[304NotModified]

Ok what method should you call to get the default behavior where SimpleLayout replaces unknown renderers with literals ?

Ow forgot about that. (I wrote it myself years ago I think, lol).

Maybe we should keep it like this then :)

[304NotModified]

Thanks!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

83.3% Coverage
0.0% Duplication

[snakefoot]

Updated wiki: https://github.com/NLog/NLog/wiki/Configure-from-code