You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reduce the level of confusion when used within services.AddLogging()-method. See also NLog/NLog#4090
Like this:
services.AddLogging(loggingBuilder =>{loggingBuilder.ClearProviders();loggingBuilder.AddNLogWeb();// fix Missing serviceProvider, so no HttpContext});
Instead of this:
services.AddLogging(loggingBuilder =>{loggingBuilder.ClearProviders();loggingBuilder.AddNLog(provider =>null);// fix Missing serviceProvider, so no HttpContext});
Guess when NLog.Extension.Logging ver. 2 with released with NLog ver. 5.0, then AddNLog can be marked as obsolete (Redirect to AddNLogWeb)
An alternative could be to also have LoadConfigurationFromSection in NLog.Web-namespace. Thus avoiding the need to have both using NLog.Web and using NLog.Logging.Extensions (Continue to have methods with name-conflicts, but making it obvious that they have different features)
An alternative could be to also have LoadConfigurationFromSection in NLog.Web-namespace. Thus avoiding the need to have both using NLog.Web and using NLog.Logging.Extensions
An alternative could be to also have LoadConfigurationFromSection in NLog.Web-namespace. Thus avoiding the need to have both using NLog.Web and using NLog.Logging.Extensions (Continue to have methods with name-conflicts, but making it obvious that they have different features)
That's fine, in the end we will move everything to Microsoft.Extensions.DependencyInjection namespace, see NLog/NLog.Extensions.Logging#421. But that will be the next major version I guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the level of confusion when used within
services.AddLogging()-method. See also NLog/NLog#4090Like this:
Instead of this:
Guess when NLog.Extension.Logging ver. 2 with released with NLog ver. 5.0, then
AddNLogcan be marked as obsolete (Redirect toAddNLogWeb)