Skip to content

${aspnet-request-posted-body}: Use Async reading to prevent "Synchronous operations are disallowed"#549

Merged
304NotModified merged 3 commits intomasterfrom
body-async
May 13, 2020
Merged

${aspnet-request-posted-body}: Use Async reading to prevent "Synchronous operations are disallowed"#549
304NotModified merged 3 commits intomasterfrom
body-async

Conversation

@304NotModified
Copy link
Member

@304NotModified 304NotModified commented Apr 19, 2020 •
edited
Loading

needs a good (real-life) test

fixes #548

@304NotModified 304NotModified modified the milestones: 4.9.2, 4.9.3 Apr 19, 2020
snakefoot
snakefoot reviewed Apr 19, 2020
View reviewed changes
@304NotModified 304NotModified marked this pull request as draft April 20, 2020 09:59
@304NotModified 304NotModified changed the base branch from dev to master April 20, 2020 10:05
@304NotModified
Copy link
Member Author

304NotModified commented May 11, 2020

Update the demo and confirm it works now:

image

@304NotModified 304NotModified marked this pull request as ready for review May 11, 2020 19:39
@304NotModified 304NotModified changed the title ${aspnet-request-posted-body}: Use Async reading for .NET standard (WIP) ${aspnet-request-posted-body}: Use Async reading for .NET standard May 11, 2020
@304NotModified 304NotModified changed the title ${aspnet-request-posted-body}: Use Async reading for .NET standard ${aspnet-request-posted-body}: Use Async reading for .NET standard platforms to prevent "Synchronous operations are disallowed" May 11, 2020
@304NotModified 304NotModified changed the title ${aspnet-request-posted-body}: Use Async reading for .NET standard platforms to prevent "Synchronous operations are disallowed" ${aspnet-request-posted-body}: Use Async reading for ASP.NET Core to prevent "Synchronous operations are disallowed" May 11, 2020
@304NotModified 304NotModified changed the title ${aspnet-request-posted-body}: Use Async reading for ASP.NET Core to prevent "Synchronous operations are disallowed" ${aspnet-request-posted-body}: Use Async reading to prevent "Synchronous operations are disallowed" May 11, 2020
@304NotModified 304NotModified mentioned this pull request May 11, 2020
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@304NotModified 304NotModified merged commit 9342736 into master May 13, 2020
@304NotModified 304NotModified deleted the body-async branch May 13, 2020 21:45
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Merged
@snakefoot
Copy link
Contributor

snakefoot commented Oct 9, 2022

Thanks to @bakgerman now NLog.Web.AspNetCore v5.1 re-introduces ${aspnet-request-posted-body} with help from middleware:

app.UseMiddleware<NLog.Web.NLogRequestPostedBodyMiddleware>();

It is no longer necessary to explicit call context.Request.EnableBuffering(); as it is handled by the middleware.

@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snakefoot snakefoot snakefoot left review comments

Assignees

No one assigned

Labels

ASP.NET Core ASP.NET Core - all versions bug size/M

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

${aspnet-request-posted-body} could throw 'Synchronous operations are disallowed' for ASP.NET Core 3

2 participants

@304NotModified @snakefoot