Skip to content

Added ThreadSafe-attribute for LayoutRenderer to optimize async Precalculate#326

Merged
304NotModified merged 1 commit intoNLog:masterfrom
snakefoot:master
Oct 31, 2018
Merged

Added ThreadSafe-attribute for LayoutRenderer to optimize async Precalculate#326
304NotModified merged 1 commit intoNLog:masterfrom
snakefoot:master

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 28, 2018

When using AsyncWrapper then logger-threads will be able to precalculate-layouts concurrently without waiting for Target-lock.

@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #326 into master will increase coverage by 1%.
The diff coverage is 89%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #326   +/-   ##
=====================================
+ Coverage      62%    63%   +1%     
=====================================
  Files          32     32           
  Lines         454    438   -16     
  Branches       97     94    -3     
=====================================
- Hits          282    275    -7     
+ Misses        135    130    -5     
+ Partials       37     33    -4
Impacted Files Coverage Δ
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs 0% <ø> (ø) ⬆️
...ore/LayoutRenderers/AspNetMvcControllerRenderer.cs 40% <ø> (ø) ⬆️
...NetCore/LayoutRenderers/AspNetMvcActionRenderer.cs 40% <ø> (ø) ⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs 71% <ø> (ø) ⬆️
...LayoutRenderers/AspNetWebRootPathLayoutRenderer.cs 0% <ø> (ø) ⬆️
...LayoutRenderers/AspNetAppBasePathLayoutRenderer.cs 0% <ø> (ø) ⬆️
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs 0% <ø> (ø) ⬆️
...e/LayoutRenderers/AssemblyVersionLayoutRenderer.cs 38% <ø> (ø) ⬆️
...ayoutRenderers/AspNetUserAuthTypeLayoutRenderer.cs 67% <ø> (ø) ⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs 75% <ø> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebb807...185629b. Read the comment docs.

@snakefoot snakefoot force-pushed the master branch 6 times, most recently from 185629b to 27f1006 Compare October 31, 2018 18:11
@snakefoot
Copy link
Contributor Author

@304NotModified Fixed merge conflicts

/// <example>
/// <code lang="NLog Layout Renderer">
/// ${aspnet-host}
/// ${aspnet-request-host}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@304NotModified
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASP.NET Core ASP.NET Core - all versions ASP.NET 4 ASP.NET MVC Classic performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants