Skip to content

Avoid boxing when using positional logging parameters #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

snakefoot
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.64%. Comparing base (3555797) to head (c8687f3).

Files with missing lines Patch % Lines
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 80.76% 2 Missing and 3 partials ⚠️
...nsions.Logging/Logging/NLogMessageParameterList.cs 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   77.57%   78.64%   +1.06%     
==========================================
  Files          19       19              
  Lines        1958     1962       +4     
  Branches      374      375       +1     
==========================================
+ Hits         1519     1543      +24     
+ Misses        278      252      -26     
- Partials      161      167       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snakefoot snakefoot merged commit 9b04c11 into NLog:master Jun 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants