Skip to content

NLog v6 RC2 #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025
Merged

NLog v6 RC2 #784

merged 4 commits into from
Jun 2, 2025

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented May 25, 2025

Upgrade to NLog v6.0 RC2 and updated to use nullable references.

Resolves #540

@snakefoot snakefoot force-pushed the nlog6 branch 2 times, most recently from 4c037ef to df77505 Compare May 26, 2025 05:14
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.37705% with 130 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (5caec9d) to head (0a3a6e5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 48.17% 67 Missing and 18 partials ⚠️
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 60.56% 19 Missing and 9 partials ⚠️
...tensions.Logging/Targets/MicrosoftILoggerTarget.cs 58.33% 1 Missing and 4 partials ⚠️
...ensions.Logging/Config/NLogLoggingConfiguration.cs 75.00% 0 Missing and 4 partials ⚠️
...tensions.Hosting/Extensions/ConfigureExtensions.cs 40.00% 1 Missing and 2 partials ⚠️
...nsions.Logging/Logging/NLogMessageParameterList.cs 86.66% 1 Missing and 1 partial ⚠️
...tensions.Logging/Extensions/ConfigureExtensions.cs 83.33% 1 Missing ⚠️
...ing/LayoutRenderers/ConfigSettingLayoutRenderer.cs 83.33% 0 Missing and 1 partial ⚠️
.../LayoutRenderers/MicrosoftConsoleLayoutRenderer.cs 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   81.21%   77.57%   -3.64%     
==========================================
  Files          19       19              
  Lines        1826     1958     +132     
  Branches      325      374      +49     
==========================================
+ Hits         1483     1519      +36     
- Misses        206      278      +72     
- Partials      137      161      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snakefoot snakefoot closed this May 27, 2025
@snakefoot snakefoot reopened this May 27, 2025
@snakefoot snakefoot force-pushed the nlog6 branch 3 times, most recently from 080aaf3 to 68ab09e Compare May 28, 2025 05:26
@snakefoot snakefoot closed this May 30, 2025
@snakefoot snakefoot reopened this May 30, 2025
@snakefoot snakefoot force-pushed the nlog6 branch 3 times, most recently from 0fa359b to 87b0893 Compare June 1, 2025 20:21
@snakefoot snakefoot changed the title NLog v6 RC1 NLog v6 RC2 Jun 1, 2025
@snakefoot snakefoot force-pushed the nlog6 branch 3 times, most recently from 03d76da to 73fcad1 Compare June 1, 2025 20:55
@snakefoot snakefoot force-pushed the nlog6 branch 2 times, most recently from e4f5265 to 0a3a6e5 Compare June 2, 2025 06:39
@snakefoot snakefoot enabled auto-merge (squash) June 2, 2025 06:41
@snakefoot snakefoot merged commit e596d64 into NLog:master Jun 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider injecting EventId properties as normal message template parameters
2 participants