Repository navigation
Improve XML docs for AddNLog and UseNLog - #710
Merged
Merged
Conversation
snakefoot
force-pushed
the
improve-xml-docs
branch
from
December 5, 2023 17:55
d91dac8 to
0649592
Compare
snakefoot
force-pushed
the
improve-xml-docs
branch
from
December 5, 2023 19:11
0649592 to
19d4a86
Compare
|
I'm not sure that "to be assigned" fully describes the case. It might be worth adding something about "LogManager will be reconfigured and recreated (include FIleTargets)" |
Contributor
Author
|
That I think is implicit by assigning a new NLog LoggingConfiguration. That targets included are also loaded and initialised.
|
Contributor
Author
|
But yes "assigned" is probably not a good word. Will change to "and loads the new NLog configuration"
And for the input-parameter "New NLog config to be loaded"
|
snakefoot
force-pushed
the
improve-xml-docs
branch
from
December 6, 2023 19:22
19d4a86 to
5863edd
Compare
snakefoot
enabled auto-merge (squash)
December 6, 2023 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #708 + #709