Skip to content

NLogLoggerProvider - Replaced dynamic assembly loading with registration methods - #669

Merged
snakefoot merged 1 commit into
NLog:masterfrom
snakefoot:master
May 30, 2023
Merged

snakefoot merged 1 commit into
NLog:masterfrom
snakefoot:master

Conversation

@snakefoot

@snakefoot snakefoot commented May 17, 2023 •

Copy link
Copy Markdown
Contributor

@codecov-commenter

codecov-commenter commented May 17, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.08 ⚠️

Comparison is base (432b12f) 80.76% compared to head (7b98b88) 80.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
- Coverage   80.76%   80.69%   -0.08%     
==========================================
  Files          19       19              
  Lines        1664     1663       -1     
  Branches      283      284       +1     
==========================================
- Hits         1344     1342       -2     
  Misses        189      189              
- Partials      131      132       +1     
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 82.13% <0.00%> (-0.35%) ⬇️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 96.96% <ø> (-0.60%) ⬇️
...Logging/Config/SetupExtensionsBuilderExtensions.cs 100.00% <100.00%> (ø)
...tensions.Logging/Extensions/ConfigureExtensions.cs 71.18% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants