Introduced LoadConfigurationFromSection on ISetupBuilder#412
Merged
304NotModified merged 1 commit intoNLog:masterfrom Mar 31, 2020
Merged
Conversation
… ISetupBuilder
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 82.45% 82.29% -0.16%
==========================================
Files 14 14
Lines 1197 1192 -5
Branches 194 195 +1
==========================================
- Hits 987 981 -6
Misses 141 141
- Partials 69 70 +1
Continue to review full report at Codecov.
|
Member
|
This is an API breaking change? The revert? |
Contributor
Author
|
We have not released anything yet. Me trying out the LogManager.Setup()-fluent-API. And decided that this works better for my eyes :) |
Member
|
ow yes indeed |
Member
|
This is indeed nicer to read :) |
snakefoot
added a commit
to snakefoot/NLog.Extensions.Logging
that referenced
this pull request
Apr 26, 2020
…nfigurationFromSection
snakefoot
added a commit
to snakefoot/NLog.Extensions.Logging
that referenced
this pull request
Apr 26, 2020
…nfigurationFromSection
snakefoot
added a commit
to snakefoot/NLog.Extensions.Logging
that referenced
this pull request
May 10, 2020
…nfigurationFromSection
304NotModified
pushed a commit
that referenced
this pull request
May 11, 2020
…urationFromSection (#418)
Member
|
note renamed before release in #418. Example and title has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded #410
Updated example: