Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edns-tcp-keepalive-timeout.
wcawijngaards
approved these changes
Mar 12, 2024
ximon18
reviewed
Mar 12, 2024
doc/unbound.conf.5.in
Outdated
| The period Unbound will wait for a query on a TCP connection when | ||
| EDNS TCP Keepalive is active. If this timeout expires Unbound closes | ||
| the connection. If the client supports the EDNS TCP Keepalive option, | ||
| Overrides \fBtcp\-idle\-timeout\fR when EDNS TCP Keepalive is active. |
There was a problem hiding this comment.
Perhaps "active" is a word commonly used in the Unbound documentation and its meaning is clear, but my concern here would be is it clear that "active" means "edns-tcp-keepalive = yes" rather than say "the current request included an edns-tcp-keepalive option or some other interpretation?
There was a problem hiding this comment.
@ximon18 fair comment, is the new text better?
ximon18
approved these changes
Mar 12, 2024
ximon18
approved these changes
Mar 12, 2024
gthess
added a commit
that referenced
this pull request
Mar 12, 2024
- Merge #1028: Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Mar 17, 2024
* nlnet/master: - For windows build, persist the openssl and expat directories for repeated builds while debugging. - Fix that addrinfo is not kept around but copied and freed, so that log-destaddr uses a copy of the information, much like NSD does. - The code repository continues with version 1.19.4. - Fix rpz for cname override action after nsdname and nsip triggers. - Fix to unify codepath for local alias for rpz cname action override. - Fix rpz that the rpz override is taken in case of clientip triggers. Fix that the clientip passthru action is logged. Fix that the clientip localdata action is logged. Fix rpz override action cname for the clientip trigger. - Fix NLnetLabs#1029: rpz trigger clientip and action rpz-passthru not working as expected. Changelog entry for NLnetLabs#1028: - Merge NLnetLabs#1028: Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout. Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout (NLnetLabs#1028) - Fix NLnetLabs#1021 Inconsistent Behavior with Changing rpz-cname-override and doing a unbound-control reload. Update doc/Changelog to note the fixes included in 1.19.3rc2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.