Make IPv6 DNSSEC tracing work, and revert to previous behaviour otherwise #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wise If drill is executed without "-6", the previous behavior continues, with only A records being used.
|
Thanks @paul-internetnz . This looks perfect. I agree that not specifying -4 or -6 should enable both A and AAAA, but I'll accept this now and hopefully someone will pick up that still missing feature sometime. |
wtoorop
added a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 DNSSEC trace ("secure trace") does not currently work because only A records are permitted for NSs that are used to trace down from the root. AAAA records are needed for that. Currently an IPv6 DNSSEC trace fails after asking the root, because drill has no valid NSs to continue with.
With this patch, if drill is executed without "-6", the previous behavior continues, with only A records being used.
This is not optimal because without the "-4" or "-6" command line parameters, drill is supposed to randomly use either v4 or v6, as indicated by the
LDNS_RR_TYPE_ANYdefault forqfamily, but there is noLDNS_RR_TYPE_A_AND_AAAARR descriptor and I don't know how to join two results of theldns_rr_listdata type.Thanks to Felipe Barbosa for reviewing and input.