Address several issues with the ultimate goal being to fix Coverity cited problems #241
Conversation
This change ignores several files which are generated by autotools, et al. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Prior to this change `dsasig` was not freed when calling `DSA_SIG_set0` failed. Free `dsasig` on error in that code path now. Reported by: Coverity Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Both `i` and `n` should match the return type for `sk_X509_num` (which is `int`, not `size_t`). This addresses a potential issue where `sk_X509_num(..)` could return -1, resulting in an unnecessary number of loop iterations and undesirable behavior. Reported by: Coverity Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
This set of changes looks nice to me. Unbound has similar issues, because it has the same code in certain places, it needs the memory leak fix and some of the spelling fixes. I have created commits to the unbound code base to fix them, in NLnetLabs/unbound@3cad581 and NLnetLabs/unbound@1974732 . |
Much appreciated! I looked at those PRs -- do I need to submit entries to the ChangeLog as well for the proposed changes, or is that something maintainers can handle? |
I should be able to handle that 😁 . How would you prefer to be credited? As ngie-eign or with your full name. |
|
]
Thanks! Could you please use my legal name (Enji Cooper) :)? |
.gitignoreto ignore more build generated files.the the->the).