Skip to content

Conversation

@sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Sep 9, 2025

Checklist before requesting a review

  • I have read the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests

Refs:

Describe the changes made in this pull request

Replaced the sentence as suggested in the issue.

Instructions to review the pull request

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref <YOUR_BRANCH> https://github.com/nlesc/python-template test_package

@sjvrijn sjvrijn requested a review from egpbos September 9, 2025 08:28
Copy link
Collaborator

@egpbos egpbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work, thank you so much for this effort @sjvrijn! Apologies that my review took so long, but I wanted to take the time to properly study the repercussions of this on adjacent concerns 😜

@egpbos egpbos merged commit f739fbd into main Sep 26, 2025
18 checks passed
@egpbos egpbos deleted the 641-fix-message branch September 26, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants