Skip to content

Conversation

@gbarter
Copy link
Member

@gbarter gbarter commented Feb 3, 2026

Purpose

The different units of OpenFAST load outputs must be taken into account better in some of the fatigue calculations, especially when using an S-N curve from the library of DNV curves available in pCrunch/fatpack.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gbarter gbarter requested a review from dzalkind February 3, 2026 15:05
Copy link
Collaborator

@dzalkind dzalkind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding, when should the units of FatigueParams be in stress vs. force?

@gbarter
Copy link
Member Author

gbarter commented Feb 4, 2026

For my own understanding, when should the units of FatigueParams be in stress vs. force?

It works for both. Depending on the input to pCrunch FatigueParams, the units may be force if interested in DELs or Stress if using more classic S-N curve models. The important piece is the units prefix (none or 'k' or 'M' etc). You can see the logic in the code at:
https://github.com/NLRWindSystems/pCrunch/blob/master/pCrunch/fatigue.py#L72

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21691761195

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.388%

Totals Coverage Status
Change from base Build 21691734977: 0.0%
Covered Lines: 8322
Relevant Lines: 14253

💛 - Coveralls

@gbarter gbarter merged commit 75f994b into develop Feb 5, 2026
18 checks passed
@gbarter gbarter deleted the tower_del_units branch February 5, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants