-
Notifications
You must be signed in to change notification settings - Fork 10
Add terse links for gradient-based calculation using graph-based collection definition #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add terse links for gradient-based calculation using graph-based collection definition #176
Conversation
Merge develop changes into main
Update installation instructions
just kidding removed references to WISDEM repo and replaced with renamed NLRWindSystems
…rd into feature/terse_links_for_orbit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request converts the collection system design representation from a discrete graph variable to a continuous terse_links array to enable gradient-based optimization. The terse_links format is a compact integer array encoding the electrical connection topology as a tree structure, where each turbine's connection target is specified by an array index.
Changes:
- Changed
terse_linksfrom a discrete output to a continuous output in collection system components to support gradient computation - Updated the ORBIT wrapper to accept
terse_linksinstead ofgraphand reconstruct the graph internally - Added partial derivative declarations indicating that
terse_linksis independent of input positions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ard/cost/orbit_wrap.py |
Modified to accept terse_links input instead of discrete graph, added logic to reconstruct graph from terse_links, and declared partials for gradient calculations |
ard/collection/optiwindnet_wrap.py |
Moved terse_links from discrete output to continuous output and added partial declarations marking it as independent of position inputs |
ard/collection/templates.py |
Updated template to define terse_links as a continuous output instead of discrete output |
test/ard/unit/cost/test_orbit_wrap.py |
Updated test connections from graph to terse_links |
test/ard/unit/collection/test_templates.py |
Updated test assertions to check for terse_links in continuous outputs instead of discrete outputs |
test/ard/unit/collection/test_optiwindnet.py |
Updated test assertions to check for terse_links in continuous outputs instead of discrete outputs |
README.md |
Updated documentation URLs to point to NLRWindSystems GitHub organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.