Eagle density function for eco-constrained design setups #168

cfrontin · 2026-01-07T19:47:44Z

Depends on #167.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request adds eagle density function capabilities for eco-constrained wind farm design optimization. It introduces components for evaluating eagle presence density at turbine locations and computing distances to exclusion zones.

Key changes include:

New EagleDensityFunction component using bivariate spline interpolation to evaluate eagle presence density from SSRS-generated maps
New FarmExclusionDistancePolygon component for computing turbine distances to polygonal exclusion regions using JAX-based autodifferentiation
Enhanced visualization support for rendering exclusion zones on layout plots

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
`ard/eco/eagle_density.py`	New OpenMDAO component implementing eagle presence density evaluation using scipy's RectBivariateSpline
`ard/layout/exclusions.py`	New OpenMDAO component for calculating turbine-to-exclusion distances with JAX-based gradient computation
`ard/viz/layout.py`	Added plotting functionality for polygonal exclusion zones with validation
`test/ard/unit/eco/test_eagle_density.py`	Unit tests for eagle density function with value and gradient validation
`test/ard/unit/eco/inputs/ard_system_eagle_density.yaml`	Test configuration with eagle density map and design variable definitions
`test/ard/unit/layout/test_exclusion.py`	Comprehensive unit tests for exclusion distance calculations (single and multi-polygon)
`test/ard/unit/layout/test_boundary.py`	Cleanup of unused imports and variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ard/eco/eagle_density.py

test/ard/unit/eco/test_eagle_density.py

test/ard/unit/eco/inputs/ard_system_eagle_density.yaml

test/ard/unit/eco/test_eagle_density.py

ard/eco/eagle_density.py

ard/viz/layout.py

test/ard/unit/eco/test_eagle_density.py

test/ard/unit/eco/inputs/ard_system_eagle_density.yaml

ard/eco/eagle_density.py

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ard/viz/layout.py

ard/eco/eagle_density.py

ard/layout/exclusions.py

test/ard/unit/eco/test_eagle_density.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…to feature/eco_eagles_field

jaredthomas68

Looks great, just a few minor things to get it ready for production

ard/eco/eagle_density.py

ard/layout/gridfarm.py

test/ard/unit/eco/inputs/ard_system_eagle_density.yaml

test/ard/unit/eco/test_eagle_density.py

…erious sign flip, sometimes...

… clean up debug statements

Feature/exclusions

…es_field

jaredthomas68

Looks good

jaredthomas68 · 2026-01-20T22:50:57Z

ard/eco/eagle_density.py

+    calculated by the National Laboratory of the Rockies's Stochastic Soaring
+    Raptor Simulator (SSRS) at the turbine locations. The eagle presence density
+    is an output of an SSRS simulation indicating the unit density function of
+    a raptor flying through the point during a given migratory period.


is it just for migration?

i think it's across the year, like the period of a wave but referring to southbound then northbound migratory flow. i snipped the language from their paper although it uses a fair amount of terminology of art and i was only skimming.

ard/layout/gridfarm.py

@jaredthomas68

* fix typos in installation instructions (#152) * Multi-objective refactor (#153) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * added first cut at multi-objective stuff * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * multi-objective refactor * fix example code * black reformat * invert erroneous exclusion * improved unit testing * get rid of pyoptsparse dependencies and broaden test coverage * fixed erroneous inclusion of options * address copilot comments * address jared's requests on #153 * add the file that i renamed the wrong way --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Add a simple viewshed component (#156) * added viewshed and empty test component. * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * viewshed should be done * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * restore change i didn't like --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove zero velocity resource for FLORIS (#160) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * removed zero velocity rows from floris results * adjust values with lt one percent error due to renormalization after wind resource pdf adjustment --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Create a new automated stdout/stderr redirection system (#161) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * prototype stdout/stderr capturing implemented. * missed a bunch, trying again. * fix bounds manager * adjust file paths * clear ipynb * remove viz script which isn't actually involved in that pr * Apply typo suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed black formatting * wip logging with iterations * black reformatting * remove messy iteration debug statements * black reformat again * update optimization demo * update logging code for error handling and docs * made stdio capture optional modeling option and updated * bring floris input file generator in with logger * added case name to address @jaredthomas68's comment on #161 * cleanup some iter_count discovery and defaulting code w/ multiple returns * updated the logging docstrings * ard system fixed * fixing stuff and added some features related to the fixes * try again to overcome windows error * add teardown to fix windows file access issue * use case_name distinction to make sure the reports end up in unique places * wip try teardown to fix file access on windows * fix discovered typo, test mistake * added another necessary teardown * forgot two more * retry * black reformat... * adjust case names for better use * black reformat... * ... stupid omission --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Bugfix/optiwindnet jitter overlapping (#163) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * updated tests to check jitter * address comments from copilot * add substation test * deal with jared's comments * black reformat and adding comments jared asked for * added convenience printing to test. * final black reformatting --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * WISDEM NSGA2 incorporation (#158) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * added NSGA2 to optimizer options * removed zero velocity rows from floris results * add example 06 * udpate * adjust pyproject to use dev branch * added gfortran for running on GH action runner * undo dev branching * black reformat plus added copilot-requested changes for viz utils * added forgotten file * add unit testing for nsga2 implementation * address @jaredthomas68 comments * add ard yaml --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Feature/goodybag (#165) * readme adjustments to address and close #154 and numpy version adjustment to close #157 * refactor the test organization for better incorporation of subpackages * black reformat * update github runner * address jared suggestions * fix logomaker (#166) * fix logomaker * black reformat * WISDEM update and configurations (#172) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * update for WISDEM/ORBIT pyrite standard value changes * fix typo --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Add domain exclusion zones via windIO (#167) * bring in the exclusions and their viz implications * added exclusion code * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * new gold standard test, weird failure * fixed value of the exclusion distance; still failing now on two: mysterious sign flip, sometimes... * add a boundary test case that lights up the strange error * rename and add some tests * added exclusion test even though it's in tatters * debugging * use switch instead of pad to fix boundary in/out identification. also clean up debug statements * black reformat * black reformat --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jared Thomas <jaredthomas68@gmail.com> * Black reformat update to 2026 stable format (#173) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * update for WISDEM/ORBIT pyrite standard value changes * black v2026 reformat --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Eagle density function for eco-constrained design setups (#168) * bring in the exclusions and their viz implications * added exclusion code * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * added eagle density code and tested it * fix filepath * improved documentation, added and tested derivatives on eagles splines * black reformat * first tranche of copilot changes * second tranche of copilot fixes * Apply suggestions from copilot code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * more consistent error messages * black reformat * new gold standard test, weird failure * fixed value of the exclusion distance; still failing now on two: mysterious sign flip, sometimes... * add a boundary test case that lights up the strange error * rename and add some tests * added exclusion test even though it's in tatters * debugging * use switch instead of pad to fix boundary in/out identification. also clean up debug statements * black reformat * black reformat * address jared comments * fix accidentally stashed and dropped changes * black reformat... * fix calling convention * black are you kidding me --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jared Thomas <jaredthomas68@gmail.com> * update org name (#170) Co-authored-by: Cory Frontin <cory.frontin@nrel.gov> * Add some helpers for "house style" plots (#174) * create house style update * update house style to actually work * Release/develop (#177) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * eliminating wrongthink just kidding removed references to WISDEM repo and replaced with renamed NLRWindSystems --------- Co-authored-by: Cory Frontin <cory.frontin@nrel.gov> * Develop backmerge (#178) * Bump version from 0.1.0-beta0 to 0.1.0-beta1 * Bump version from 0.1.0-beta1 to 0.1.0-beta2 * eliminating wrongthink just kidding removed references to WISDEM repo and replaced with renamed NLRWindSystems --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Update ard/utils/geometry.py Remove pad_polygon * Update test/ard/unit/utils/test_geometry.py Remove tests for no longer used `pad_polygon` function * Update docs/testing.md Remove duplicate line Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * correct connection x->y is now x->x * run black * Update ard/viz/house_style.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * correct turbine connections and remove unused gplot import * run black --------- Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jared Thomas <jaredthomas68@gmail.com> Co-authored-by: Pietro Bortolotti <ptrbortolotti@gmail.com>

cfrontin and others added 5 commits January 6, 2026 16:55

bring in the exclusions and their viz implications

1057a94

added exclusion code

c08b5b7

Apply suggestions from code review

7a7110e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

added eagle density code and tested it

11f2466

fix filepath

469093d

cfrontin self-assigned this Jan 7, 2026

cfrontin added 2 commits January 7, 2026 13:56

improved documentation, added and tested derivatives on eagles splines

923deb2

black reformat

6a7545f

cfrontin requested a review from Copilot January 7, 2026 21:06

Copilot started reviewing on behalf of cfrontin January 7, 2026 21:07 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

cfrontin added 2 commits January 7, 2026 15:20

first tranche of copilot changes

8191c9f

second tranche of copilot fixes

eabd1e9

cfrontin requested a review from Copilot January 7, 2026 22:36

Copilot started reviewing on behalf of cfrontin January 7, 2026 22:36 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

cfrontin and others added 4 commits January 7, 2026 15:45

Apply suggestions from copilot code review

ec3255e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

more consistent error messages

9b620cd

Merge branch 'feature/eco_eagles_field' of github.com:cfrontin/Ard in…

c2bfb64

…to feature/eco_eagles_field

black reformat

5f06bb4

jaredthomas68 requested changes Jan 9, 2026

View reviewed changes

cfrontin and others added 9 commits January 13, 2026 13:24

Merge branch 'develop' of github.com:WISDEM/Ard into feature/exclusions

62d4eca

Merge branch 'feature/exclusions' into feature/eco_eagles_field

133276d

new gold standard test, weird failure

44c1b37

fixed value of the exclusion distance; still failing now on two: myst…

8dd81f8

…erious sign flip, sometimes...

add a boundary test case that lights up the strange error

bfc06f9

rename and add some tests

1a83abf

added exclusion test even though it's in tatters

2b11ec6

debugging

473c89a

use switch instead of pad to fix boundary in/out identification. also…

31cbca9

… clean up debug statements

cfrontin added 12 commits January 16, 2026 09:42

black reformat

cd8ada3

Merge branch 'feature/exclusions' into feature/exclusions

507a934

Merge pull request #6 from jaredthomas68/feature/exclusions

4eb52b5

Feature/exclusions

black reformat

c7d9425

Merge branch 'feature/exclusions' into feature/eco_eagles_field

b551ff9

Merge branch 'develop' of github.com:WISDEM/Ard into feature/exclusions

6682379

Merge branch 'feature/exclusions' into feature/eco_eagles_field

a821c2b

Merge branch 'develop' of github.com:WISDEM/Ard into feature/eco_eagl…

238b9f0

…es_field

address jared comments

3ed37cd

Merge branch 'develop' of github.com:WISDEM/Ard into feature/eco_eagl…

7499864

…es_field

fix accidentally stashed and dropped changes

9b86e2c

black reformat...

265d703

cfrontin marked this pull request as ready for review January 20, 2026 20:43

cfrontin added 2 commits January 20, 2026 14:08

fix calling convention

0187464

black are you kidding me

3ddf3c5

cfrontin requested a review from jaredthomas68 January 20, 2026 21:53

jaredthomas68 approved these changes Jan 20, 2026

View reviewed changes

cfrontin merged commit 52a7ce8 into NLRWindSystems:develop Jan 21, 2026
30 checks passed

cfrontin deleted the feature/eco_eagles_field branch January 21, 2026 03:47

Eagle density function for eco-constrained design setups #168

Eagle density function for eco-constrained design setups #168

Uh oh!

Conversation

cfrontin commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaredthomas68 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaredthomas68 left a comment

Choose a reason for hiding this comment

Uh oh!

jaredthomas68 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

cfrontin Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants