Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-bind and conversion-partition parameters #14

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

maartenpaul
Copy link
Member

  1. Added slurm_data_bind_path parameter

    • Enables custom bind paths for Singularity/Apptainer containers
    • Allows proper access to storage locations outside default mounts in container
  2. Added slurm_conversion_partition parameter

    • Enables specifying a dedicated Slurm partition for data conversion jobs
    • Allows resource allocation for conversion tasks when required

Copy link
Collaborator

@TorecLuik TorecLuik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er prima uit.

Maar, voeg ze dan ook even toe aan de example slurm-config.ini (https://github.com/maartenpaul/biomero/blob/slurm-parameter/resources/slurm-config.ini ), met een beschrijving van wat ze doen / example van hoe het eruit zou zien.

En onze favoriete test coverage app zegt dat je 3 van je 12 toegevoegde lines gemist heb en daarmee onze test coverage omlaag haalt ;)

https://coveralls.io/builds/72609684

@TorecLuik TorecLuik merged commit cc34cef into NL-BioImaging:main Mar 19, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants