SlicerSALT updates #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and options Removes setting of unused variables: ITK_CXX_DISABLE_OPTIMIZATION_FLAG ITK_LIBRARY_BUILD_TYPE ITK_REQUIRED_C_FLAGS ITK_REQUIRED_CXX_FLAGS ITK_REQUIRED_LINK_FLAGS ITK_USE_64BITS_APPLE_TRUNCATION_WARNING
jcfr
force-pushed
the
slicersalt-2018-11-26-92fb222
branch
from
9eaba2c to
762825c
Compare
…ILD_SHARED_LIBS Setting option BUILD_SHARED_LIBS is not required for the following reasons: * the ShapePopulationViewWidget library is always built statically * setting BUILD_SHARED_LIBS to OFF is causing the ShapePopulationViewer module to be statically build which is not supported. Windows build error was the following: qSlicerShapePopulationViewerModuleWidget::staticMetaObject': definition of dllimport static data member not allowed Finally, explicitly include the ITKSetStandardCompilerFlags CMake module to ensure the correct version is included.
jcfr
force-pushed
the
slicersalt-2018-11-26-92fb222
branch
from
762825c to
8112d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.