-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
43 events gallery of photos #203
base: develop
Are you sure you want to change the base?
Conversation
Would it be possible to generalize the gallery to activity? We were discussing this today and think that projects benefit from a gallery too for all the images in their details page |
Of course! I'll get onto it :) |
Check the documentation preview: https://65c247bae925ce12954d3af9--niaefeup-backend-docs.netlify.app |
Hi @AvilaAndre are the alterations now ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions so far, will look at the tests after these changes :)
src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/ErrorMessages.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/controller/EventController.kt
Outdated
Show resolved
Hide resolved
...tlin/pt/up/fe/ni/website/backend/utils/documentation/payloadschemas/model/PayloadActivity.kt
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Rita Lopes <93883163+MRita443@users.noreply.github.com>
Check the documentation preview: https://67129de7cdd15a87bce58df2--niaefeup-backend-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things:
- Tests are missing for
Project
- Tests are missing the documentation functions
Rest is mostly questions and things my IDE nagged me about :)
src/main/kotlin/pt/up/fe/ni/website/backend/service/upload/CloudinaryFileUploader.kt
Show resolved
Hide resolved
src/test/kotlin/pt/up/fe/ni/website/backend/controller/EventControllerTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/pt/up/fe/ni/website/backend/controller/EventControllerTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/pt/up/fe/ni/website/backend/utils/mockmvc/MockMvcMultipartBuilder.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt
Outdated
Show resolved
Hide resolved
…bstractActivityService.kt Co-authored-by: Rita Lopes <93883163+MRita443@users.noreply.github.com>
…MvcMultipartBuilder.kt Co-authored-by: Rita Lopes <93883163+MRita443@users.noreply.github.com>
Check the documentation preview: https://672b6109beadb96db6cad65e--niaefeup-backend-docs.netlify.app |
Check the documentation preview: https://672b62a7ae6d590f327f8d9e--niaefeup-backend-docs.netlify.app |
Also, regarding the documentation, I don't think it'll be possible for now because #144 is still open, my bad! |
Check the documentation preview: https://672b6b5b000bd476a2798c62--niaefeup-backend-docs.netlify.app |
Check the documentation preview: https://672b94dfaeab8117c5de781c--niaefeup-backend-docs.netlify.app |
Check the documentation preview: https://672d1d2d364cc84188fab553--niaefeup-backend-docs.netlify.app |
Check the documentation preview: https://672d1eca338bf63f7924d3d7--niaefeup-backend-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! This ended up being a bit more than expected but you handled it well, good eye catching all the slug mentions too :)
Closes #43
Creates the endpoints to manage events' photos.
Review checklist