Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

43 events gallery of photos #203

Open
wants to merge 40 commits into
base: develop
Choose a base branch
from
Open

Conversation

AvilaAndre
Copy link
Contributor

Closes #43

Creates the endpoints to manage events' photos.

Review checklist

  • Behavior is as expected
  • Clean, well structured code
  • Properly documents API changes in the corresponding controller test
  • Contains enough appropriate tests
  • Changes are reflected in the Wiki if necessary

@AvilaAndre AvilaAndre linked an issue Nov 21, 2023 that may be closed by this pull request
@MRita443
Copy link
Collaborator

Would it be possible to generalize the gallery to activity? We were discussing this today and think that projects benefit from a gallery too for all the images in their details page

@AvilaAndre
Copy link
Contributor Author

Would it be possible to generalize the gallery to activity? We were discussing this today and think that projects benefit from a gallery too for all the images in their details page

Of course! I'll get onto it :)

@AvilaAndre AvilaAndre marked this pull request as ready for review February 6, 2024 14:23
Copy link

github-actions bot commented Feb 6, 2024

Check the documentation preview: https://65c247bae925ce12954d3af9--niaefeup-backend-docs.netlify.app

@MRita443
Copy link
Collaborator

Hi @AvilaAndre are the alterations now ready?

Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions so far, will look at the tests after these changes :)

Copy link

Check the documentation preview: https://67129de7cdd15a87bce58df2--niaefeup-backend-docs.netlify.app

Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things:

  • Tests are missing for Project
  • Tests are missing the documentation functions

Rest is mostly questions and things my IDE nagged me about :)

AvilaAndre and others added 4 commits November 6, 2024 12:21
…bstractActivityService.kt

Co-authored-by: Rita Lopes <93883163+MRita443@users.noreply.github.com>
…MvcMultipartBuilder.kt

Co-authored-by: Rita Lopes <93883163+MRita443@users.noreply.github.com>
Copy link

github-actions bot commented Nov 6, 2024

Check the documentation preview: https://672b6109beadb96db6cad65e--niaefeup-backend-docs.netlify.app

Copy link

github-actions bot commented Nov 6, 2024

Check the documentation preview: https://672b62a7ae6d590f327f8d9e--niaefeup-backend-docs.netlify.app

@MRita443
Copy link
Collaborator

MRita443 commented Nov 6, 2024

I was just testing this out on Postman and noticed a couple more things
image

The image of the event itself has an incorrect port, perhaps we should fix that in this PR too.
Also, I think maybe using the slug would be better than the title for the filename

@MRita443
Copy link
Collaborator

MRita443 commented Nov 6, 2024

Also, regarding the documentation, I don't think it'll be possible for now because #144 is still open, my bad!

@AvilaAndre
Copy link
Contributor Author

I was just testing this out on Postman and noticed a couple more things image

The image of the event itself has an incorrect port, perhaps we should fix that in this PR too. Also, I think maybe using the slug would be better than the title for the filename

Did that event already exist on your machine?
3000 is the port that was hardcoded before. I already replaced that with 8080.

@AvilaAndre
Copy link
Contributor Author

AvilaAndre commented Nov 6, 2024

Also, regarding the documentation, I don't think it'll be possible for now because #144 is still open, my bad!

I already added some, the multipart is missing, maybe we just add that after #144 is finished.

Update: Already figured out why I can't use it.

Copy link

github-actions bot commented Nov 6, 2024

Check the documentation preview: https://672b6b5b000bd476a2798c62--niaefeup-backend-docs.netlify.app

@MRita443
Copy link
Collaborator

MRita443 commented Nov 6, 2024

I was just testing this out on Postman and noticed a couple more things image
The image of the event itself has an incorrect port, perhaps we should fix that in this PR too. Also, I think maybe using the slug would be better than the title for the filename

Did that event already exist on your machine? 3000 is the port that was hardcoded before. I already replaced that with 8080.

Yep you're right! Created another one and it's correct

Copy link

github-actions bot commented Nov 6, 2024

Check the documentation preview: https://672b94dfaeab8117c5de781c--niaefeup-backend-docs.netlify.app

Copy link

github-actions bot commented Nov 7, 2024

Check the documentation preview: https://672d1d2d364cc84188fab553--niaefeup-backend-docs.netlify.app

Copy link

github-actions bot commented Nov 7, 2024

Check the documentation preview: https://672d1eca338bf63f7924d3d7--niaefeup-backend-docs.netlify.app

Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! This ended up being a bit more than expected but you handled it well, good eye catching all the slug mentions too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

events: gallery of photos
3 participants