Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms and conditions optimization #987

Merged
merged 9 commits into from
Dec 18, 2023

Conversation

coutinho21
Copy link
Contributor

Closes #848

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #987 (8e29c1a) into develop (6edba2d) will increase coverage by 1%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #987   +/-   ##
======================================
+ Coverage       16%    16%   +1%     
======================================
  Files          207    207           
  Lines         6487   6483    -4     
======================================
  Hits          1004   1004           
+ Misses        5483   5479    -4     

Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed a useless test file and this is ready to go.

@bdmendes bdmendes requested a review from a team December 16, 2023 12:52
@thePeras thePeras merged commit 43484df into develop Dec 18, 2023
@thePeras thePeras deleted the feature/terms-and-conditions-optimization branch December 18, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not fetch terms from GH
3 participants