Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry bug report #925

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Sentry bug report #925

merged 4 commits into from
Sep 10, 2023

Conversation

thePeras
Copy link
Member

Closes #792
No more automatically GitHub issues created from user report, removing service secret from beeing send with in the app bundle.
When user submits an report, captureMessage creates a new sentry Event and a user feedback is appended to it.
Also, a sentry Alert Rule was created to send the user feeback to an appropriate slack channel, so everyone interested can be notify and start a discussion with the others.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@bdmendes bdmendes marked this pull request as ready for review August 24, 2023 22:33
@bdmendes bdmendes self-requested a review September 10, 2023 10:49
@thePeras thePeras force-pushed the feature/sentry-bug-feature-report branch from e33a9ef to aba0544 Compare September 10, 2023 11:25
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #925 (12f5a9d) into develop (9087e05) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #925   +/-   ##
======================================
  Coverage       22%    22%           
======================================
  Files          136    136           
  Lines         3539   3539           
======================================
  Hits           759    759           
  Misses        2780   2780           

Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice job 🚀

@bdmendes bdmendes merged commit b57cb7f into develop Sep 10, 2023
@bdmendes bdmendes deleted the feature/sentry-bug-feature-report branch September 10, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send GitHub bug/feature issue from sentry
3 participants