Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix card adders popup #869

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix card adders popup #869

merged 1 commit into from
Jul 27, 2023

Conversation

bdmendes
Copy link
Collaborator

Closes #868

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@bdmendes bdmendes force-pushed the fix/redundant-faculties branch from 4000efb to 54b0a5b Compare July 23, 2023 12:18
Sirze01
Sirze01 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to work on testing the app. This bug was a simple fix. Nice catch.

@bdmendes bdmendes force-pushed the fix/redundant-faculties branch from 54b0a5b to 7ee23b3 Compare July 27, 2023 11:08
@bdmendes bdmendes requested a review from thePeras July 27, 2023 11:08
LuisDuarte1
LuisDuarte1 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch! 🎉

@LuisDuarte1 LuisDuarte1 merged commit b8e833c into develop Jul 27, 2023
@LuisDuarte1 LuisDuarte1 deleted the fix/redundant-faculties branch July 27, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@Sirze01 Sirze01 Sirze01 approved these changes

@thePeras thePeras Awaiting requested review from thePeras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card adders popup is broken
3 participants
@bdmendes @LuisDuarte1 @Sirze01