Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/schedule helper funcions #796

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Refactor/schedule helper funcions #796

merged 5 commits into from
Jul 20, 2023

Conversation

Rica320
Copy link
Contributor

@Rica320 Rica320 commented Apr 26, 2023

Closes #780
Removes helper functions from schedule view.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

bdmendes
bdmendes previously approved these changes Jul 3, 2023
View reviewed changes
@bdmendes bdmendes requested a review from Sirze01 July 5, 2023 13:46
Sirze01
Sirze01 previously approved these changes Jul 6, 2023
View reviewed changes
@bdmendes bdmendes added this to the Mid-Summer 2023 Release milestone Jul 12, 2023
@Sirze01 Sirze01 dismissed stale reviews from bdmendes and themself via 280fae5 July 20, 2023 20:58
@Sirze01 Sirze01 requested review from Sirze01 and bdmendes July 20, 2023 20:59
Sirze01
Sirze01 previously approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving due to stale review.

@Sirze01 Sirze01 self-requested a review July 20, 2023 21:11
@Sirze01 Sirze01 force-pushed the refactor/schedule-helper-funcions branch from 280fae5 to ebc2c97 Compare July 20, 2023 21:34
@Sirze01 Sirze01 force-pushed the refactor/schedule-helper-funcions branch from ebc2c97 to c384f24 Compare July 20, 2023 21:35
Sirze01
Sirze01 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving due to stale review

@bdmendes bdmendes merged commit cff1e49 into develop Jul 20, 2023
@bdmendes bdmendes deleted the refactor/schedule-helper-funcions branch July 20, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sirze01 Sirze01 Sirze01 approved these changes

@bdmendes bdmendes bdmendes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Back to School 2023
Development

Successfully merging this pull request may close these issues.

Refactor Schedule helper functions
3 participants
@Rica320 @Sirze01 @bdmendes