Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app freezing when creating toast messages #783

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

thePeras
Copy link
Member

Closes #727

Basically, there was a problem with contexts.
When creating a new reference, the created dialog was initializing a new isolated context. That context was being passed to the toast and used it to close the message after a period of time. However, the dialog was already closed when the toast tried to close itself, and it wasn't being able to do it.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@jlcrodrigues jlcrodrigues merged commit 9b435dd into develop Apr 26, 2023
@jlcrodrigues jlcrodrigues deleted the fix/app-freezing-toast-message branch April 26, 2023 15:05
@jlcrodrigues jlcrodrigues mentioned this pull request Jun 28, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App freezing when creating print reference
3 participants