Restaurant card on the widgets menu #738

DGoiana · 2023-03-01T15:53:08Z

Closes #730
Added the restaurant card to the widgets menu.

Review checklist

Terms and conditions reflect the current change
Contains enough appropriate tests
If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
Properly adds an entry in changelog.md with the change
If PR includes UI updates/additions, its description has screenshots
Behavior is as expected
Clean, well-structured code

bdmendes · 2023-03-01T21:12:17Z

@DGoiana can you add screenshots?

DGoiana · 2023-03-02T10:04:15Z

@DGoiana can you add screenshots?

added

bdmendes · 2023-03-03T07:05:36Z

Why is the card empty?

DGoiana · 2023-03-03T08:53:07Z

Why is the card empty?

Issue #390 maybe.

…bility Merge with providers branch to connect the restaurant data

DGoiana · 2023-03-03T22:59:35Z

Meanwhile the data from the restaurants menu is already visible in the home card. However, for now, only one restaurant menu can be seen.

bdmendes · 2023-03-04T15:19:19Z

Awesome, good progress. We can now focus on refining the design (I'm not a fan of the red dividers) and allowing multiple restaurants to appear.

DGoiana · 2023-03-16T12:21:09Z

Favorite restaurants feature is now available (still needing a card redesign). Only the favorite ones will appear in the home menu. While commiting found a bug where the sequence of the meals on the home menu card is incorrect in some restaurants.

uni/lib/view/home/widgets/restaurant_card.dart

DGoiana · 2023-03-16T15:04:48Z

The order of the icons and correspondent meals is now correct.

uni/lib/view/restaurant/restaurant_page_view.dart

uni/lib/view/restaurant/widgets/restaurant_page_card.dart

uni/lib/view/restaurant/restaurant_page_view.dart

uni/lib/view/home/widgets/restaurant_card.dart

bdmendes · 2023-07-18T17:44:03Z

@thePeras the balance card now has a subtitle for 'referencias'. Do you think that that subtitle in any way is relatable to these restaurante names? Can we generalize the card subtitle?

DGoiana · 2023-07-20T20:19:02Z

Redesign as suggested

uni/lib/view/home/widgets/restaurant_card.dart

uni/lib/model/providers/lazy/restaurant_provider.dart

uni/lib/view/restaurant/widgets/restaurant_page_card.dart

uni/lib/model/providers/lazy/restaurant_provider.dart

uni/lib/view/restaurant/restaurant_page_view.dart

uni/lib/model/providers/lazy/restaurant_provider.dart

codecov · 2023-08-11T16:54:58Z

Codecov Report

Merging #738 (2a120a4) into develop (40311a2) will decrease coverage by 0%.
Report is 2 commits behind head on develop.
The diff coverage is 0%.

Additional details and impacted files

@@          Coverage Diff           @@
##           develop   #738   +/-   ##
======================================
- Coverage       22%    22%   -0%     
======================================
  Files          136    136           
  Lines         3511   3532   +21     
======================================
  Hits           746    746           
- Misses        2765   2786   +21

bdmendes

Looks good to me

uni/lib/utils/favorite_widget_type.dart

LuisDuarte1

Good work!

DGoiana and others added 2 commits March 1, 2023 15:51

Restaurant card on the widgets menu

6478dde

Merge branch 'develop' into fix/restaurant-card-visibility

e2261e3

DGoiana requested a review from brunogomes30 March 1, 2023 16:10

DGoiana requested a review from bdmendes March 2, 2023 10:04

DGoiana added 2 commits March 3, 2023 15:41

Merge branch 'refactor/state-providers' into fix/restaurant-card-visi…

72f1fd0

…bility Merge with providers branch to connect the restaurant data

Restaurants data connected to the home card

e0df756

DGoiana changed the base branch from develop to refactor/state-providers March 3, 2023 22:51

Base automatically changed from refactor/state-providers to develop March 4, 2023 14:45

DGoiana and others added 4 commits March 6, 2023 14:00

Merge branch 'develop' into fix/restaurant-card-visibility

88e3800

Merge branch 'develop' into fix/restaurant-card-visibility

a407001

Favorite restaurants feature

d179dce

Lint fixing

6d83bc7

thePeras reviewed Mar 16, 2023

View reviewed changes

uni/lib/view/home/widgets/restaurant_card.dart Outdated Show resolved Hide resolved

DGoiana and others added 3 commits March 16, 2023 14:27

Minor redesign

f9c2cfa

Merge branch 'develop' into fix/restaurant-card-visibility

ed476fe

Bug fixing

2c396e9

bdmendes requested changes Mar 16, 2023

View reviewed changes

uni/lib/view/restaurant/restaurant_page_view.dart Outdated Show resolved Hide resolved

uni/lib/view/restaurant/widgets/restaurant_page_card.dart Show resolved Hide resolved

DGoiana and others added 4 commits March 18, 2023 16:57

Merge branch 'develop' into fix/restaurant-card-visibility

ebdacb8

Implementation of card action

24227fe

Merge branch 'develop' into fix/restaurant-card-visibility

439e177

Cleaning codespace

d32009b

bdmendes requested changes Mar 22, 2023

View reviewed changes

uni/lib/view/restaurant/restaurant_page_view.dart Outdated Show resolved Hide resolved

uni/lib/view/restaurant/restaurant_page_view.dart Outdated Show resolved Hide resolved

uni/lib/view/home/widgets/restaurant_card.dart Outdated Show resolved Hide resolved

Card redesign

003666b

DGoiana and others added 3 commits July 20, 2023 22:06

Lazy providers merge

f271385

Merge branch 'develop' into fix/restaurant-card-visibility

cb08d22

Merge branch 'develop' into fix/restaurant-card-visibility

bf6ce4d

Sirze01 requested a review from bdmendes July 20, 2023 23:20

bdmendes requested changes Jul 22, 2023

View reviewed changes

uni/lib/view/home/widgets/restaurant_card.dart Outdated Show resolved Hide resolved

uni/lib/model/providers/lazy/restaurant_provider.dart Outdated Show resolved Hide resolved

DGoiana added 2 commits July 24, 2023 22:35

Weekday and restart bug fix

98f2169

Conflicts solving

03b3d33

DGoiana requested a review from bdmendes July 24, 2023 21:40

DGoiana and others added 2 commits July 25, 2023 00:14

Format fix

59abeb9

Merge branch 'develop' into fix/restaurant-card-visibility

b1f2725

bdmendes requested changes Jul 27, 2023

View reviewed changes

Merge branch 'develop' into fix/restaurant-card-visibility

afd66c3

Sirze01 requested changes Jul 27, 2023

View reviewed changes

uni/lib/model/providers/lazy/restaurant_provider.dart Outdated Show resolved Hide resolved

DGoiana added 2 commits August 11, 2023 16:53

Removing useless methods and completers

8a0a19c

Conflicts solving

5a1071c

DGoiana requested review from Sirze01 and bdmendes August 12, 2023 21:54

bdmendes approved these changes Aug 13, 2023

View reviewed changes

bdmendes requested a review from LuisDuarte1 August 24, 2023 09:12

bdmendes requested changes Aug 24, 2023

View reviewed changes

uni/lib/utils/favorite_widget_type.dart Outdated Show resolved Hide resolved

DGoiana and others added 2 commits August 25, 2023 14:33

Restaurant widget moved to the bottom

d7769fb

Merge branch 'develop' into fix/restaurant-card-visibility

2a120a4

bdmendes approved these changes Aug 25, 2023

View reviewed changes

LuisDuarte1 approved these changes Aug 25, 2023

View reviewed changes

bdmendes merged commit 6a0cf07 into develop Aug 25, 2023

bdmendes deleted the fix/restaurant-card-visibility branch August 25, 2023 15:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restaurant card on the widgets menu #738

Restaurant card on the widgets menu #738

DGoiana commented Mar 1, 2023 •

edited

Loading

bdmendes commented Mar 1, 2023

DGoiana commented Mar 2, 2023

bdmendes commented Mar 3, 2023

DGoiana commented Mar 3, 2023

DGoiana commented Mar 3, 2023

bdmendes commented Mar 4, 2023

DGoiana commented Mar 16, 2023

DGoiana commented Mar 16, 2023 •

edited

Loading

bdmendes commented Jul 18, 2023

DGoiana commented Jul 20, 2023

codecov bot commented Aug 11, 2023 •

edited

Loading

bdmendes left a comment

LuisDuarte1 left a comment

Restaurant card on the widgets menu #738

Restaurant card on the widgets menu #738

Conversation

DGoiana commented Mar 1, 2023 • edited Loading

Review checklist

bdmendes commented Mar 1, 2023

DGoiana commented Mar 2, 2023

bdmendes commented Mar 3, 2023

DGoiana commented Mar 3, 2023

DGoiana commented Mar 3, 2023

bdmendes commented Mar 4, 2023

DGoiana commented Mar 16, 2023

DGoiana commented Mar 16, 2023 • edited Loading

bdmendes commented Jul 18, 2023

DGoiana commented Jul 20, 2023

codecov bot commented Aug 11, 2023 • edited Loading

Codecov Report

bdmendes left a comment

Choose a reason for hiding this comment

LuisDuarte1 left a comment

Choose a reason for hiding this comment

DGoiana commented Mar 1, 2023 •

edited

Loading

DGoiana commented Mar 16, 2023 •

edited

Loading

codecov bot commented Aug 11, 2023 •

edited

Loading