Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert icon to adaptive icon on Android #735

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Convert icon to adaptive icon on Android #735

merged 3 commits into from
Mar 1, 2023

Conversation

GustavoASantos
Copy link
Contributor

@GustavoASantos GustavoASantos commented Feb 28, 2023 •
edited
Loading

Converted the icon to an Adaptive Icon on Android so it looks the same on every device. Also includes support for Android 13's themed icons.

Adaptive Icon

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

bdmendes
bdmendes previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contributing.

thePeras
thePeras requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove changes on uni/ios/ folder

As Apple says "The App Store Icon can't be transparent nor contain an alpha channel."

After that, it's good to go!
Thanks for the contribution

Sirze01
Sirze01 previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing. The new icons look great!

@GustavoASantos GustavoASantos dismissed stale reviews from Sirze01 and bdmendes via a3f0e4b March 1, 2023 14:43
bdmendes
bdmendes previously approved these changes Mar 1, 2023
View reviewed changes
@GustavoASantos GustavoASantos requested a review from thePeras March 1, 2023 15:06
thePeras
thePeras approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

@bdmendes bdmendes merged commit c5f9f8d into NIAEFEUP:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras approved these changes

@bdmendes bdmendes bdmendes approved these changes

@Sirze01 Sirze01 Sirze01 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GustavoASantos @thePeras @Sirze01 @bdmendes