-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/Add Faculties to bug report #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however it has code from another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are expanding bug report contents, it now makes sense to create a model. For example, you are forgetting here to submit the faculty to Sentry since data is being passed "raw" to the submitters and only the GH handler is querying the faculty. Passing the BugReport
class solves this.
7c2f596
to
89be70c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not being sent to Sentry. Also, take a look at my suggestion above, about encapsulating the bug report data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good, just a single comment
Closes #616
Adding faculties as one of the labels in the Github for bug reports so it's easier to identify where the bug came from.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change