Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/Add Faculties to bug report #652

Merged
merged 13 commits into from
Feb 23, 2023
Merged

Conversation

rubuy-74
Copy link
Contributor

Closes #616
Adding faculties as one of the labels in the Github for bug reports so it's easier to identify where the bug came from.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes new summary in whatsnew/whatsnew-pt-PT
  • Properly adds entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well structured code

Copy link
Contributor

@brunogomes30 brunogomes30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however it has code from another PR.

Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are expanding bug report contents, it now makes sense to create a model. For example, you are forgetting here to submit the faculty to Sentry since data is being passed "raw" to the submitters and only the GH handler is querying the faculty. Passing the BugReport class solves this.

@bdmendes bdmendes force-pushed the feature/faculties-to-bug-report branch from 7c2f596 to 89be70c Compare December 8, 2022 12:20
@rubuy-74 rubuy-74 requested a review from bdmendes December 16, 2022 19:20
Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not being sent to Sentry. Also, take a look at my suggestion above, about encapsulating the bug report data

bdmendes
bdmendes previously approved these changes Feb 3, 2023
Copy link
Contributor

@brunogomes30 brunogomes30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good, just a single comment

@bdmendes bdmendes merged commit 4134972 into develop Feb 23, 2023
@bdmendes bdmendes deleted the feature/faculties-to-bug-report branch February 23, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add faculties to bug report
3 participants