CODE RUB: Updates for Product 3 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CODE RUB
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to incorporate DecisionType retrieval in the consumer adoption workflow and optimizes batch processing queries for better performance.
- Adds DecisionType service dependency to ConsumerOrchestrationService to fetch and populate DecisionType data
- Refactors batch query logic in ConsumerAdoptionService to use separate ID lists with Contains instead of composite key matching with Any
- Removes unused test constant
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ConsumerOrchestrationService.cs | Added DecisionTypeService dependency and logic to retrieve and assign DecisionType to decisions |
| ConsumerAdoptionService.cs | Refactored batch filtering to use separate ID lists with Contains for improved query performance |
| PatientOrchestrationServiceTests.cs | Removed unused notificationRequestCountdownSeconds constant |
| ConsumerOrchestrationServiceTests.cs | Added DecisionTypeService mock to support new dependency |
| ConsumerAdoptionServiceTests.BulkAddOrModifyBatch.Logic.cs | Updated test logic to match refactored batch filtering approach |
...nDataServices.IDecide.Core/Services/Orchestrations/Consumers/ConsumerOrchestrationService.cs
Show resolved
Hide resolved
...nDataServices.IDecide.Core/Services/Foundations/ConsumerAdoptions/ConsumerAdoptionService.cs
Outdated
Show resolved
Hide resolved
...ces/Foundations/ConsumerAdoptions/ConsumerAdoptionServiceTests.BulkAddOrModifyBatch.Logic.cs
Outdated
Show resolved
Hide resolved
...nDataServices.IDecide.Core/Services/Foundations/ConsumerAdoptions/ConsumerAdoptionService.cs
Outdated
Show resolved
Hide resolved
...ces/Foundations/ConsumerAdoptions/ConsumerAdoptionServiceTests.BulkAddOrModifyBatch.Logic.cs
Outdated
Show resolved
Hide resolved
cjdutoit
requested changes
Nov 27, 2025
...ces/Foundations/ConsumerAdoptions/ConsumerAdoptionServiceTests.BulkAddOrModifyBatch.Logic.cs
Outdated
Show resolved
Hide resolved
...nDataServices.IDecide.Core/Services/Foundations/ConsumerAdoptions/ConsumerAdoptionService.cs
Outdated
Show resolved
Hide resolved
...nDataServices.IDecide.Core/Services/Foundations/ConsumerAdoptions/ConsumerAdoptionService.cs
Outdated
Show resolved
Hide resolved
...nDataServices.IDecide.Core/Services/Foundations/ConsumerAdoptions/ConsumerAdoptionService.cs
Outdated
Show resolved
Hide resolved
cjdutoit
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AB#25839