Skip to content

INTEGRATIONS: ConsumerStatus AdoptPatientDecisions #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjdutoit merged 5 commits into from
Oct 29, 2025
Merged

INTEGRATIONS: ConsumerStatus AdoptPatientDecisions #174

cjdutoit merged 5 commits into from
Oct 29, 2025

Conversation

@mehranrashid
Copy link
Contributor

@mehranrashid mehranrashid commented Oct 21, 2025 •
edited
Loading

Closes AB#25400

image

Copilot AI review requested due to automatic review settings October 21, 2025 14:24
Copilot AI reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces functionality for adopting patient decisions through a consumer status API endpoint, enabling consumers to adopt existing patient decisions with proper test coverage.

Key changes:

  • Added AdoptPatientDecisions API endpoint with supporting broker methods
  • Implemented integration and acceptance tests for the adopt patient decisions workflow
  • Refactored query logic in ConsumerAdoptionService to materialize collections before filtering

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
LondonDataServices.IDecide.Manage.Server.Tests.Integration/Models/ConsumerStatuses/Decision.cs Defines Decision model for integration tests with patient and decision type relationships
LondonDataServices.IDecide.Manage.Server.Tests.Integration/Brokers/ApiBroker.AdoptPatientDecisions.cs Adds broker method to call AdoptPatientDecisions API endpoint
LondonDataServices.IDecide.Manage.Server.Tests.Integration/Apis/ConsumerStatuses/ConsumerStatusTests.cs Provides test infrastructure and helper methods for consumer status integration tests
LondonDataServices.IDecide.Manage.Server.Tests.Integration/Apis/ConsumerStatuses/ConsumerStatusTests.AdoptPatientDecisions.cs Implements integration test verifying patient decision adoption workflow
LondonDataServices.IDecide.Manage.Server.Tests.Acceptance/Models/ConsumerStatuses/Decision.cs Defines Decision model for acceptance tests matching integration test structure
LondonDataServices.IDecide.Manage.Server.Tests.Acceptance/Brokers/ApiBroker.ConsumerStatus.cs Adds acceptance test broker method for AdoptPatientDecisions endpoint
LondonDataServices.IDecide.Manage.Server.Tests.Acceptance/Apis/ConsumerStatuses/ConsumerStatusTests.cs Provides test infrastructure and helper methods for consumer status acceptance tests
LondonDataServices.IDecide.Manage.Server.Tests.Acceptance/Apis/ConsumerStatuses/ConsumerStatusTests.AdoptPatientDecisions.cs Implements acceptance test with additional consumer cleanup logic
LondonDataServices.IDecide.Core/Services/Foundations/ConsumerAdoptions/ConsumerAdoptionService.cs Refactors batch filtering to materialize query results before composite key matching

@mehranrashid mehranrashid force-pushed the users/mehranrashid/integration-consumerStatus-adoptPatientDecisions branch from aa588b3 to 2280c77 Compare October 21, 2025 15:08
@mehranrashid mehranrashid added the INTEGRATIONS The integration tests category label Oct 21, 2025
@mehranrashid mehranrashid changed the title Users/mehranrashid/integration consumer status adopt patient decisions INTEGRATIONS: ConsumerStatus AdoptPatientDecisions Oct 21, 2025
Copilot AI review requested due to automatic review settings October 22, 2025 10:16
@mehranrashid mehranrashid force-pushed the users/mehranrashid/integration-consumerStatus-adoptPatientDecisions branch from 2280c77 to 255d33c Compare October 22, 2025 10:16
Copilot AI reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

@cjdutoit cjdutoit requested a review from JParkesAD October 22, 2025 10:26
@mehranrashid mehranrashid force-pushed the users/mehranrashid/integration-consumerStatus-adoptPatientDecisions branch from 255d33c to 584288c Compare October 22, 2025 11:06
Copilot AI review requested due to automatic review settings October 23, 2025 16:10
@mehranrashid mehranrashid marked this pull request as ready for review October 23, 2025 16:11
Copilot AI reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

cjdutoit
cjdutoit requested changes Oct 23, 2025
View reviewed changes
Copilot AI review requested due to automatic review settings October 24, 2025 14:34
@mehranrashid mehranrashid force-pushed the users/mehranrashid/integration-consumerStatus-adoptPatientDecisions branch from 628e027 to 10a1cd3 Compare October 24, 2025 14:34
Copilot AI reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings October 28, 2025 09:29
Copilot AI reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

@mehranrashid mehranrashid force-pushed the users/mehranrashid/integration-consumerStatus-adoptPatientDecisions branch from d81398b to 114f5f5 Compare October 28, 2025 13:31
Copilot AI review requested due to automatic review settings October 28, 2025 15:21
@cjdutoit cjdutoit removed the request for review from JParkesAD October 28, 2025 15:21
Copilot AI reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.

@cjdutoit cjdutoit merged commit 02bc332 into main Oct 29, 2025
5 checks passed
@cjdutoit cjdutoit deleted the users/mehranrashid/integration-consumerStatus-adoptPatientDecisions branch October 29, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@cjdutoit cjdutoit cjdutoit approved these changes

Assignees

No one assigned

Labels

INTEGRATIONS The integration tests category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mehranrashid @cjdutoit