-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPA-3543: add initial /Consent endpoint and associated schema refactoring #105
Conversation
5e03ea6
to
1069970
Compare
…erified relationship and a proxy relationship
… surface ODS code
1069970
to
6ea611f
Compare
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-3543 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all changes and made sure that the OAS incorporates all previous changes as well. Approved
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-3543 |
9034f42
to
8e6fcbe
Compare
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-3543 |
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-3543 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments made and removal of outcome
Ticket Link
https://nhsd-jira.digital.nhs.uk/browse/NPA-3543
Description/Change Summary
These changes to the OAS cover the new
/Consent
API endpoint required for requesting proxy relationships from VRS. For each proxy relationship, there should be three resources:status
)Draft requirements can be found in confluence here (along with details of how to map NAM payloads to FHIR resources): https://nhsd-confluence.digital.nhs.uk/display/NPA/Consent+endpoint+requirements
A summary of expected behaviour of the endpoint:
status
and_include
query string parameter filters)performer:identifier
parameter should be used for querying the local cachestatus
parameter should be used for filtering the relationships (based on theconsent.status
property_include
parameter should be used for including referenced resourcesHow to test?
No behaviour has been implemented as part of this change. Changes best reviewed in a swagger editor in addition to the raw changes
Of special note, ensure the previous two commits have been correctly incorporated into the spec due to these being merged manually.
Review Checklist
ℹ️ This section is to be filled in by the reviewer.