Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: [AEA-3993] - Add SBOM generation and scanning #1222

Merged
merged 34 commits into from
Aug 29, 2024
Merged

Conversation

wildjames
Copy link
Contributor

Summary

  • 🤖 Operational or Infrastructure Change

Details

Add a github workflow that generates a software bill of materials (SBOM), and scans it for vulnerabilities. Any critical warnings will cause the pipeline to fail.

Copy link
Contributor

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@wildjames
Copy link
Contributor Author

There are a few problems with our NPM packages. We need to sort these out! I've filtered out all non-critical warnings.

NAME                   INSTALLED  FIXED-IN  TYPE  VULNERABILITY        SEVERITY 
gen-mapping            0.3.5                npm   GHSA-8rmg-jf7p-4p22  Critical  
lodash                 4.17.0     4.17.12   npm   GHSA-jf85-cpcp-j695  Critical  
lodash-es              4.17.12    4.17.14   npm   GHSA-jf85-cpcp-j695  Critical  
middleware-user-agent  3.637.0              npm   GHSA-7jfr-mfm3-p4mh  Critical  
node-config-provider   3.1.4                npm   GHSA-p2f3-jr96-8rhf  Critical  
protocol-http          4.1.0                npm   GHSA-p57r-cpw5-9h67  Critical  
sandbox                1.0.0                npm   GHSA-gc25-3vc5-2jf9  Critical  
smithy-client          3.2.0                npm   GHSA-xh9p-w3hh-pqp5  Critical

Note that some of these don't have solutions that we can apply easily. We can look up the vulnerability codes here

@wildjames
Copy link
Contributor Author

Sonar complains that some code in a tests directory is not covered by tests... It's a one-line change, we should probably force merge past it.

@wildjames wildjames enabled auto-merge (squash) August 29, 2024 12:49
Copy link

sonarcloud bot commented Aug 29, 2024

@wildjames wildjames merged commit 50a85bd into main Aug 29, 2024
9 checks passed
@wildjames wildjames deleted the AEA-3993-Add-SBOM branch August 29, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants