Skip to content

Comments

SPINEDEM-5192 Create privileged access mode#1149

Merged
agelledi merged 16 commits intomasterfrom
feature/dayi2-SPINEDEM-5192-create-privileged-access-mode
Jun 30, 2025
Merged

SPINEDEM-5192 Create privileged access mode#1149
agelledi merged 16 commits intomasterfrom
feature/dayi2-SPINEDEM-5192-create-privileged-access-mode

Conversation

@dlzhry2nhs
Copy link
Contributor

@dlzhry2nhs dlzhry2nhs commented Jun 11, 2025

Summary

  • ✨ New Feature

Key Changes:
Proxy logic:

  • Adds an additional form of Level 3 application restricted access mode named privileged-application-restricted
  • Logic added to proxy flow to account for this new scope and access mode
  • Several RaiseFault components updated to dynamically include the access mode as a string in the error message
  • Refactored the regex used for scope checking. Validated through manual testing of expression and the full regression set of pipeline tests (the code is in the infrastructure definitions rather than a JS file, so is trickier to unit test).

Tests

  • Adds new tests for privileged access mode. For now, expected behaviour is identical to standard application-restricted. In the next PR, once the spine side changes are available, we will need to add assertions to verify that S-Flag details are returned in privileged access mode
  • A new Apigee app was added which specifically has privileged access mode. Pipelines and env vars updated accordingly.

Reviews Required

  • Dev
  • Test

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.

@github-actions
Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-5192

@dlzhry2nhs dlzhry2nhs mentioned this pull request Jun 13, 2025
6 tasks
@dlzhry2nhs dlzhry2nhs marked this pull request as ready for review June 17, 2025 13:07
@dlzhry2nhs dlzhry2nhs force-pushed the feature/dayi2-SPINEDEM-5192-create-privileged-access-mode branch from f937a05 to 3323577 Compare June 17, 2025 13:16
fabianmcgibbon
fabianmcgibbon previously approved these changes Jun 17, 2025
@dlzhry2nhs dlzhry2nhs force-pushed the feature/dayi2-SPINEDEM-5192-create-privileged-access-mode branch from bbb2761 to e1996b4 Compare June 20, 2025 15:34
@dlzhry2nhs dlzhry2nhs force-pushed the feature/dayi2-SPINEDEM-5192-create-privileged-access-mode branch from 2608995 to 23708a5 Compare June 25, 2025 08:08
@sonarqubecloud
Copy link

@agelledi agelledi merged commit fef3b12 into master Jun 30, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants