Skip to content

APPT-XXX Kick bad test data and make variable easier to bump #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsed-nhs merged 1 commit into from
Jan 5, 2026
Merged

APPT-XXX Kick bad test data and make variable easier to bump #1278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/client/testing/availability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ type CancelDailyAppointment = {
services: string;
};

//update this number to stop datetime test collisionsß∂
//TODO this needs remedying ASAP as this is crap.
export const staticHackyDayIncrementToBump = 119;

//session test cases to verify, should have session&booking data in the seeder
export const sessionTestCases: SessionTestCase[] = [
{
Expand Down
34 changes: 19 additions & 15 deletions src/client/testing/tests/availability/availability.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ import {
getDateInFuture,
} from '../../utils/date-utility';
import { parseToUkDatetime } from '@services/timeService';
import { sessionTestCases, weekTestCases } from '../../availability';
import {
sessionTestCases,
staticHackyDayIncrementToBump,
weekTestCases,
} from '../../availability';
import EditServicesPage from '../../page-objects/view-availability-appointment-pages/edit-services-page';
import EditServicesConfirmedPage from '../../page-objects/view-availability-appointment-pages/edit-services-confirmed';

Expand Down Expand Up @@ -65,7 +69,7 @@ test.describe('Create Availability', () => {
});

test('Create single session of RSV availability', async ({ page }) => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;
const futureDate = getDateInFuture(dayIncrement);
await createAvailabilityPage.createAvailabilityButton.click();
await page.waitForURL(`**/site/${site.id}/create-availability/wizard`);
Expand Down Expand Up @@ -93,7 +97,7 @@ test.describe('Create Availability', () => {
test('Create single session of RSV and Covid availability', async ({
page,
}) => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;
const futureDate = getDateInFuture(dayIncrement);
await createAvailabilityPage.createAvailabilityButton.click();
await page.waitForURL(`**/site/${site.id}/create-availability/wizard`);
Expand Down Expand Up @@ -121,7 +125,7 @@ test.describe('Create Availability', () => {
});

test('Create weekly session of RSV availability', async ({ page }) => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;
const futureDate = getDateInFuture(dayIncrement);
const dayAfterFutureDate = getDateInFuture(dayIncrement + 1);
await createAvailabilityPage.createAvailabilityButton.click();
Expand Down Expand Up @@ -159,7 +163,7 @@ test.describe('Create Availability', () => {
test('Create weekly session of RSV and Covid availability', async ({
page,
}) => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;

const futureDate = getDateInFuture(dayIncrement);
const dayAfterFutureDate = getDateInFuture(dayIncrement + 1);
Expand Down Expand Up @@ -244,7 +248,7 @@ test.describe('Create Availability', () => {
});

test('Create weekly session of RSV availability check summary page links', async () => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;
const futureDate = getDateInFuture(dayIncrement);
const dayAfterTomorrowDate = getDateInFuture(dayIncrement + 1);
await createAvailabilityPage.createAvailabilityButton.click();
Expand Down Expand Up @@ -300,7 +304,7 @@ test.describe('Create Availability', () => {
});

test('Create single session of RSV availability check summary page links', async () => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;
const futureDate = getDateInFuture(dayIncrement);
await createAvailabilityPage.createAvailabilityButton.click();
await expect(createAvailabilityPage.sessionTitle).toBeVisible();
Expand Down Expand Up @@ -394,7 +398,7 @@ test.describe('Update Session', () => {
test('Verify user is able to add a session for future date', async ({
page,
}) => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;

const day = daysFromToday(dayIncrement);
const requiredDate = daysFromToday(dayIncrement, 'dddd D MMMM');
Expand Down Expand Up @@ -438,7 +442,7 @@ test.describe('Update Session', () => {
test('Verify add availability option displayed for future date', async ({
page,
}) => {
const dayIncrement = 340;
const dayIncrement = staticHackyDayIncrementToBump + 7;

const day = daysFromToday(dayIncrement);
const requiredDate = daysFromToday(dayIncrement, 'dddd D MMMM');
Expand Down Expand Up @@ -467,7 +471,7 @@ test.describe('Update Session', () => {
});

test('Verify user is able to change availability', async ({ page }) => {
const dayIncrement = 226;
const dayIncrement = staticHackyDayIncrementToBump;

const day = daysFromToday(dayIncrement);
const requiredDate = daysFromToday(dayIncrement, 'dddd D MMMM');
Expand Down Expand Up @@ -523,7 +527,7 @@ test.describe('Update Session', () => {
test('Verify user is able to reduce services for availability', async ({
page,
}) => {
const dayIncrement = 227;
const dayIncrement = staticHackyDayIncrementToBump + 1;

const day = daysFromToday(dayIncrement);
const requiredDate = daysFromToday(dayIncrement, 'dddd D MMMM');
Expand Down Expand Up @@ -646,7 +650,7 @@ test.describe('Update Session', () => {
});

test('Verify user is able to cancel session', async ({ page }) => {
const dayIncrement = 228;
const dayIncrement = staticHackyDayIncrementToBump + 2;

const day = daysFromToday(dayIncrement);
const requiredDate = daysFromToday(dayIncrement, 'dddd D MMMM');
Expand Down Expand Up @@ -701,7 +705,7 @@ test.describe('Update Session', () => {
});

test('Verify session not canceled if not confirmed', async ({ page }) => {
const dayIncrement = 229;
const dayIncrement = staticHackyDayIncrementToBump + 3;

const day = daysFromToday(dayIncrement);
const requiredDate = daysFromToday(dayIncrement, 'dddd D MMMM');
Expand Down Expand Up @@ -761,7 +765,7 @@ test.describe('Update Session', () => {
});

test('Verify view daily appointment link displayed', async ({ page }) => {
const dayIncrement = 230;
const dayIncrement = staticHackyDayIncrementToBump + 4;

const day = daysFromToday(dayIncrement);
const requiredDate = daysFromToday(dayIncrement, 'dddd D MMMM');
Expand Down Expand Up @@ -841,7 +845,7 @@ test.describe('Update Session', () => {
test('Verify availability with no bookings is cancelled and manual appointments folder is empty', async ({
page,
}) => {
const dayIncrement = 260;
const dayIncrement = staticHackyDayIncrementToBump + 5;

const day = daysFromToday(dayIncrement);
const formattedDate1 = parseToUkDatetime(day).format('DD MMMM');
Expand Down