[NDR-290] Allow incoming FHIR to exclude type and author. #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
tim-knight-nhs
previously approved these changes
Dec 9, 2025
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
commented
Dec 9, 2025
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
matthewpotter2-nhs
previously approved these changes
Dec 9, 2025
megan-bower4
previously approved these changes
Dec 10, 2025
jameslinnell
dismissed stale reviews from megan-bower4 and matthewpotter2-nhs
via
2ae469b
jameslinnell
force-pushed
the
NDR-290
branch
from
e359cdf to
2ae469b
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
force-pushed
the
NDR-290
branch
from
2ae469b to
a856ac2
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
lambdas/tests/unit/services/test_post_fhir_document_reference_service.py
Outdated
Show resolved
Hide resolved
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
force-pushed
the
NDR-290
branch
from
2820751 to
5983695
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
previously approved these changes
Dec 11, 2025
tim-knight-nhs
previously approved these changes
Dec 11, 2025
jameslinnell
dismissed stale reviews from tim-knight-nhs and megan-bower4
via
76134bd
jameslinnell
force-pushed
the
NDR-290
branch
from
5983695 to
76134bd
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
|
tim-knight-nhs
approved these changes
Dec 11, 2025
megan-bower4
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: NDR-290
Description
FHIR expects author and type to be optional, however the code expects Author to exist in the request payload. This meant that if author or type was not provided then it would fail. This is not fhir compliant. This allows author to be optional.
Context
So that PDM doesn't have to send an arbitary Author across in the payload.
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)Deploy - Sandbox- Sandbox : ndr290SANDBOX Full- Deploy feature branch to sandbox- Full Deploy to ndr290